code review 8449043: go.crypto/ssh/test: wait on sshd process in tests

go.crypto/ssh/test: wait on sshd process in tests

[albert.strasheim, 2013-04-06 18:22:09]

Hello dave@cheney.net (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[dave_cheney.net, 2013-04-07 08:50:19]

Hello,

This change looks good. Did it cause a failure in your test environment, or is
this just general hygiene ?

Cheers

Dave

[albert.strasheim, 2013-04-07 08:58:02]

On 2013/04/07 08:50:19, dfc wrote:
> Hello,
> This change looks good. Did it cause a failure in your test environment, or is
> this just general hygiene ?
> Cheers

If you have a program that runs the ssh test binary repeatedly, like:

https://github.com/alberts/gostress2

the zombies pile up and you eventually hit your process limit.

[dave_cheney.net, 2013-04-07 09:22:47]

LGTM. Thank you for the explanation, I understand the problem now.

[dave_cheney.net, 2013-04-07 09:27:03]

*** Submitted as
https://code.google.com/p/go/source/detail?r=ca43617ec9b3&repo=crypto ***

go.crypto/ssh/test: wait on sshd process in tests

R=dave
CC=golang-dev
https://codereview.appspot.com/8449043

Committer: Dave Cheney <dave@cheney.net>