environs: Add []NetworkInfo to StartInstance

environs: Add []NetworkInfo to StartInstance

This does not introduce new logic, just changes
the StartInstance() return values (across all
providers) to include a slice of NetworkInfo,
which will be used in a follow-up by the MAAS
provider to report what networks and network
interfaces will be configured for the instance.

https://code.launchpad.net/~dimitern/juju-core/383-environs-startinstance-networks/+merge/214297

Requires: https://code.launchpad.net/~dimitern/juju-core/382-api-provisioner-machine-nics/+merge/214272

(do not edit description out of merge proposal)

[dimitern, 2014-04-04 16:03:57]

Please take a look.

[fwereade, 2014-04-04 16:47:14]

LGTM, but I'd really like to see the nil values tested explicitly rather than
discarded with _.

https://codereview.appspot.com/84470044/diff/1/environs/broker.go
File environs/broker.go (right):

https://codereview.appspot.com/84470044/diff/1/environs/broker.go#newcode42
environs/broker.go:42: NetworkName   string
Yeah, FWIW I think this is more of an environs.NetworkId or something (like
instance.Id before it got its own package).

Mid-term, the juju model will want to distinguish between provider ids and juju
names for the same networks. But for now I think we're ok...

https://codereview.appspot.com/84470044/diff/1/provider/maas/environ.go
File provider/maas/environ.go (left):

https://codereview.appspot.com/84470044/diff/1/provider/maas/environ.go#oldco...
provider/maas/environ.go:383: // TODO(bug 1193998) - return instance hardware
characteristics as well
ha.

[gz, 2014-04-04 16:47:39]

LGTM. I'd like a bug filed or something as followup for making our StartInstance
interface less pants.

https://codereview.appspot.com/84470044/diff/1/environs/broker.go
File environs/broker.go (right):

https://codereview.appspot.com/84470044/diff/1/environs/broker.go#newcode42
environs/broker.go:42: NetworkName   string
Againt, NetworkName might not be the best naming, and I worry a bit we'll need
to fiddle with the other memebers in the near future, but leave as is for now,
should be fine.

[dimitern, 2014-04-04 17:38:50]

https://codereview.appspot.com/84470044/diff/1/environs/broker.go
File environs/broker.go (right):

https://codereview.appspot.com/84470044/diff/1/environs/broker.go#newcode42
environs/broker.go:42: NetworkName   string
On 2014/04/04 16:47:14, fwereade wrote:
> Yeah, FWIW I think this is more of an environs.NetworkId or something (like
> instance.Id before it got its own package).
> 
> Mid-term, the juju model will want to distinguish between provider ids and
juju
> names for the same networks. But for now I think we're ok...

Yes, we can change it later (and we will most definitely change it by the time
we have complete networking support).

https://codereview.appspot.com/84470044/diff/1/environs/broker.go#newcode42
environs/broker.go:42: NetworkName   string
On 2014/04/04 16:47:39, gz wrote:
> Againt, NetworkName might not be the best naming, and I worry a bit we'll need
> to fiddle with the other memebers in the near future, but leave as is for now,
> should be fine.

Noted, but it will do for now.

https://codereview.appspot.com/84470044/diff/1/provider/maas/environ.go
File provider/maas/environ.go (left):

https://codereview.appspot.com/84470044/diff/1/provider/maas/environ.go#oldco...
provider/maas/environ.go:383: // TODO(bug 1193998) - return instance hardware
characteristics as well
On 2014/04/04 16:47:14, fwereade wrote:
> ha.

Indeed!