Issue 84410043: code review 84410043: runtime: fix plan9 warning.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84410043: code review 84410043: runtime: fix plan9 warning. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by khr

Modified:
11 years, 2 months ago

Reviewers:
aram

CC:
0intro, aram, golang-codereviews

Visibility:
Public.

Description

runtime: fix plan9 warning. I have no idea what this code is for, but it pretty clearly needs to be uint64, not uint32.

Patch Set 2 : diff -r 0bf0c11aea78 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0bf0c11aea78 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 3188f9e48f0f https://code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/os_plan9_amd64.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

khr

Hello 0intro@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 2 months ago (2014-04-04 06:22:14 UTC) #1

aram

FWIW, plan9/amd64 doesn't work at all. https://codereview.appspot.com/84410043/diff/40001/src/pkg/runtime/os_plan9_amd64.c File src/pkg/runtime/os_plan9_amd64.c (right): https://codereview.appspot.com/84410043/diff/40001/src/pkg/runtime/os_plan9_amd64.c#newcode98 src/pkg/runtime/os_plan9_amd64.c:98: ureg->sp = (uint64)sp; ...

11 years, 2 months ago (2014-04-04 09:49:56 UTC) #2

khr

11 years, 2 months ago (2014-04-04 15:15:28 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2e0890c1d9d6 ***

runtime: fix plan9 warning.

I have no idea what this code is for, but it pretty
clearly needs to be uint64, not uint32.

LGTM=aram
R=0intro, aram
CC=golang-codereviews
https://codereview.appspot.com/84410043

Expand All Messages | Collapse All Messages