Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 8437043: code review 8437043: misc: update zsh completion (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by titanous
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, minux1
Visibility:
Public.

Description

misc: update zsh completion

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 1d49ee511d95 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M misc/zsh/go View 1 5 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 5
titanous
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 1 month ago (2013-04-06 01:46:10 UTC) #1
minux1
https://codereview.appspot.com/8437043/diff/1/misc/zsh/go File misc/zsh/go (left): https://codereview.appspot.com/8437043/diff/1/misc/zsh/go#oldcode101 misc/zsh/go:101: 'importpath[description of import paths]' \ s/importpath[description of import paths]/packages[description ...
12 years, 1 month ago (2013-04-06 09:23:47 UTC) #2
titanous
On 2013/04/06 09:23:47, minux wrote: > https://codereview.appspot.com/8437043/diff/1/misc/zsh/go > File misc/zsh/go (left): > > https://codereview.appspot.com/8437043/diff/1/misc/zsh/go#oldcode101 > ...
12 years, 1 month ago (2013-04-06 14:32:18 UTC) #3
minux1
LGTM. Thank you.
12 years, 1 month ago (2013-04-06 14:49:50 UTC) #4
minux1
12 years, 1 month ago (2013-04-06 20:11:24 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=7767d71dcc7b ***

misc: update zsh completion

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/8437043

Committer: Shenghou Ma <minux.ma@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b