local provider: check for juju-local

local provider: check for juju-local

Check only for juju-local in the local
provider as mongodb-server, cpu-checker
and rsyslog-gnutls are all dependencies
of juju-local.

https://code.launchpad.net/~waigani/juju-core/1301353-mongodb-dep/+merge/214156

(do not edit description out of merge proposal)

[thumper, 2014-04-07 03:06:40]

You have gone a bit too far with some of the checks.

We only need to touch the local provider prereqs.

https://codereview.appspot.com/84360043/diff/1/cmd/jujud/upgrade_test.go
File cmd/jujud/upgrade_test.go (right):

https://codereview.appspot.com/84360043/diff/1/cmd/jujud/upgrade_test.go#newc...
cmd/jujud/upgrade_test.go:101: // juju-local should have been installed.
This is not the right place to change this one.

This test is explicitly checking that rsyslog-gnutls has been installed due to
changes in logging requirements.

https://codereview.appspot.com/84360043/diff/1/container/kvm/initialisation.go
File container/kvm/initialisation.go (right):

https://codereview.appspot.com/84360043/diff/1/container/kvm/initialisation.g...
container/kvm/initialisation.go:47: const neetToInstallKVMOk = `kvm-ok is not
installed. Please install the juju-local package.
Again, wrong place.  kvm-ok is in the cpu-checker package.

https://codereview.appspot.com/84360043/diff/1/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/84360043/diff/1/environs/cloudinit/cloudinit.g...
environs/cloudinit/cloudinit.go:223: c.AddPackage("juju-local")
This is definitely wrong.  Cloud-init is what we install on all the cloud
images.

https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go
File provider/local/prereqs.go (right):

https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go#newc...
provider/local/prereqs.go:60: // I'm not sure what the path should be?
We don't need this any more

https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go#newc...
provider/local/prereqs.go:99: return errors.New(installJujuLocalUbuntu)
I'm pretty happy to just have this error returned in all cases.

We can deal with the local provider in other platforms when it happens.

[waigani, 2014-04-07 04:43:27]

Running "go test -gocheck.f TestOpenFailsWithProtectedDirectories" in
provider/local raises the original make dir test fail: Juju should not be able
to create the dirs but can. My permissions are as follows:

ls -la /usr/lib | grep "juju"
drwxr-xr-x   5 root root         4096 Apr  4 17:00 juju
drwxr-xr-x   4 root root         4096 Apr  1 15:33 juju-1.17.7

If the fail is due to my perms, wouldn't this be a test isolation issue?

https://codereview.appspot.com/84360043/diff/1/cmd/jujud/upgrade_test.go
File cmd/jujud/upgrade_test.go (right):

https://codereview.appspot.com/84360043/diff/1/cmd/jujud/upgrade_test.go#newc...
cmd/jujud/upgrade_test.go:101: // juju-local should have been installed.
On 2014/04/07 03:06:40, thumper wrote:
> This is not the right place to change this one.
> 
> This test is explicitly checking that rsyslog-gnutls has been installed due to
> changes in logging requirements.

Done.

https://codereview.appspot.com/84360043/diff/1/container/kvm/initialisation.go
File container/kvm/initialisation.go (right):

https://codereview.appspot.com/84360043/diff/1/container/kvm/initialisation.g...
container/kvm/initialisation.go:47: const neetToInstallKVMOk = `kvm-ok is not
installed. Please install the juju-local package.
On 2014/04/07 03:06:40, thumper wrote:
> Again, wrong place.  kvm-ok is in the cpu-checker package.

Done.

https://codereview.appspot.com/84360043/diff/1/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/84360043/diff/1/environs/cloudinit/cloudinit.g...
environs/cloudinit/cloudinit.go:223: c.AddPackage("juju-local")
On 2014/04/07 03:06:40, thumper wrote:
> This is definitely wrong.  Cloud-init is what we install on all the cloud
> images.

Note to self: I should really take a moment to discuss and understand what I'm
doing before I go and do it.

https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go
File provider/local/prereqs.go (right):

https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go#newc...
provider/local/prereqs.go:60: // I'm not sure what the path should be?
On 2014/04/07 03:06:40, thumper wrote:
> We don't need this any more

Done.

https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go#newc...
provider/local/prereqs.go:99: return errors.New(installJujuLocalUbuntu)
On 2014/04/07 03:06:40, thumper wrote:
> I'm pretty happy to just have this error returned in all cases.
> 
> We can deal with the local provider in other platforms when it happens.

Done.

[waigani, 2014-04-07 04:45:56]

On 2014/04/07 04:43:27, waigani wrote:
> Running "go test -gocheck.f TestOpenFailsWithProtectedDirectories" in
> provider/local raises the original make dir test fail: Juju should not be able
> to create the dirs but can. My permissions are as follows:
> 
> ls -la /usr/lib | grep "juju"
> drwxr-xr-x   5 root root         4096 Apr  4 17:00 juju
> drwxr-xr-x   4 root root         4096 Apr  1 15:33 juju-1.17.7
> 
> If the fail is due to my perms, wouldn't this be a test isolation issue?
> 
> https://codereview.appspot.com/84360043/diff/1/cmd/jujud/upgrade_test.go
> File cmd/jujud/upgrade_test.go (right):
> 
>
https://codereview.appspot.com/84360043/diff/1/cmd/jujud/upgrade_test.go#newc...
> cmd/jujud/upgrade_test.go:101: // juju-local should have been installed.
> On 2014/04/07 03:06:40, thumper wrote:
> > This is not the right place to change this one.
> > 
> > This test is explicitly checking that rsyslog-gnutls has been installed due
to
> > changes in logging requirements.
> 
> Done.
> 
> https://codereview.appspot.com/84360043/diff/1/container/kvm/initialisation.go
> File container/kvm/initialisation.go (right):
> 
>
https://codereview.appspot.com/84360043/diff/1/container/kvm/initialisation.g...
> container/kvm/initialisation.go:47: const neetToInstallKVMOk = `kvm-ok is not
> installed. Please install the juju-local package.
> On 2014/04/07 03:06:40, thumper wrote:
> > Again, wrong place.  kvm-ok is in the cpu-checker package.
> 
> Done.
> 
> https://codereview.appspot.com/84360043/diff/1/environs/cloudinit/cloudinit.go
> File environs/cloudinit/cloudinit.go (right):
> 
>
https://codereview.appspot.com/84360043/diff/1/environs/cloudinit/cloudinit.g...
> environs/cloudinit/cloudinit.go:223: c.AddPackage("juju-local")
> On 2014/04/07 03:06:40, thumper wrote:
> > This is definitely wrong.  Cloud-init is what we install on all the cloud
> > images.
> 
> Note to self: I should really take a moment to discuss and understand what I'm
> doing before I go and do it.
> 
> https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go
> File provider/local/prereqs.go (right):
> 
>
https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go#newc...
> provider/local/prereqs.go:60: // I'm not sure what the path should be?
> On 2014/04/07 03:06:40, thumper wrote:
> > We don't need this any more
> 
> Done.
> 
>
https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go#newc...
> provider/local/prereqs.go:99: return errors.New(installJujuLocalUbuntu)
> On 2014/04/07 03:06:40, thumper wrote:
> > I'm pretty happy to just have this error returned in all cases.
> > 
> > We can deal with the local provider in other platforms when it happens.
> 
> Done.

"go test -gocheck.f TestOpenFailsWithProtectedDirectories" also fails on trunk
for me. My guess is that it is my perms. Can you confirm what my perms should be
and is this an isolation issue that should be fixed in test setup?

[waigani, 2014-04-08 00:42:57]

Please take a look.

[waigani, 2014-04-08 00:44:47]

Please take a look.

[thumper, 2014-04-09 05:09:09]

LGTM with the spelling fixed.

https://codereview.appspot.com/84360043/diff/60001/container/kvm/initialisati...
File container/kvm/initialisation.go (right):

https://codereview.appspot.com/84360043/diff/60001/container/kvm/initialisati...
container/kvm/initialisation.go:48: sudo apt-get install cpu-ckecker`
You have mis-spelled checker