Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(520)

Issue 84330043: code review 84330043: syscall: use unsafe.Pointer instead of uintptr on windo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by brainman
Modified:
6 years, 9 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

syscall: use unsafe.Pointer instead of uintptr on windows when possible Fixes issue 7171

Patch Set 1 #

Patch Set 2 : diff -r 1474b280d7aa https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1474b280d7aa https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 88b3b2fa4dde https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/pkg/syscall/syscall_windows.go View 1 7 chunks +12 lines, -12 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_amd64.go View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
brainman
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
6 years, 9 months ago (2014-04-04 05:06:46 UTC) #1
iant
LGTM
6 years, 9 months ago (2014-04-04 13:59:57 UTC) #2
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=b958fefe50a7 *** syscall: use unsafe.Pointer instead of uintptr on windows when possible ...
6 years, 9 months ago (2014-04-06 02:18:12 UTC) #3
gobot
This CL appears to have broken the linux-386 builder. See http://build.golang.org/log/18a359c3bd4995e194d624ce77c1b225b0cdb9b4
6 years, 9 months ago (2014-04-06 02:31:01 UTC) #4
brainman
6 years, 9 months ago (2014-04-06 02:39:00 UTC) #5
Message was sent while issue was closed.
On 2014/04/06 02:31:01, gobot wrote:
> This CL appears to have broken the linux-386 builder.
> See http://build.golang.org/log/18a359c3bd4995e194d624ce77c1b225b0cdb9b4

I don't think so.

--- FAIL: TestSetPanicOnFault (0.00 seconds)
	runtime_test.go:199: still here - should have faulted on address 0xfff00001
	runtime_test.go:192: did not find error in recover
FAIL
FAIL	runtime	10.977s

Alex
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b