Issue 84330043: code review 84330043: syscall: use unsafe.Pointer instead of uintptr on windo...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84330043: code review 84330043: syscall: use unsafe.Pointer instead of uintptr on windo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by brainman

Modified:
10 years ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

syscall: use unsafe.Pointer instead of uintptr on windows when possible Fixes issue 7171

Patch Set 1 #

Patch Set 2 : diff -r 1474b280d7aa https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1474b280d7aa https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 88b3b2fa4dde https://go.googlecode.com/hg/ #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
M	src/pkg/syscall/syscall_windows.go	View	1	7 chunks	+12 lines, -12 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_windows_386.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_windows_amd64.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years ago (2014-04-04 05:06:46 UTC) #1

brainman

*** Submitted as https://code.google.com/p/go/source/detail?r=b958fefe50a7 *** syscall: use unsafe.Pointer instead of uintptr on windows when possible ...

10 years ago (2014-04-06 02:18:12 UTC) #3

gobot

This CL appears to have broken the linux-386 builder. See http://build.golang.org/log/18a359c3bd4995e194d624ce77c1b225b0cdb9b4

10 years ago (2014-04-06 02:31:01 UTC) #4

brainman

10 years ago (2014-04-06 02:39:00 UTC) #5

Message was sent while issue was closed.

On 2014/04/06 02:31:01, gobot wrote:
> This CL appears to have broken the linux-386 builder.
> See http://build.golang.org/log/18a359c3bd4995e194d624ce77c1b225b0cdb9b4

I don't think so.

--- FAIL: TestSetPanicOnFault (0.00 seconds)
	runtime_test.go:199: still here - should have faulted on address 0xfff00001
	runtime_test.go:192: did not find error in recover
FAIL
FAIL	runtime	10.977s

Alex

Expand All Messages | Collapse All Messages