Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(136)

Issue 84290044: provider/azure: ensure tests work correctly

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by axw
Modified:
10 years ago
Reviewers:
wallyworld, mp+214147
Visibility:
Public.

Description

provider/azure: ensure tests work correctly Some tests I wrote call StartInstance to check the parameters passed to createInstance. The tests don't actually verify that it called that method successfully, and all validation is done within the method. Updated the tests to ensure from outside that the method is called. https://code.launchpad.net/~axwalk/juju-core/azure-test-ensure-called/+merge/214147 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : provider/azure: ensure tests work correctly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -51 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M provider/azure/environ_test.go View 1 7 chunks +99 lines, -51 lines 0 comments Download

Messages

Total messages: 4
axw
Please take a look.
10 years ago (2014-04-04 02:01:26 UTC) #1
wallyworld
LGTM. I think thst one big test should / could be split up with a ...
10 years ago (2014-04-04 04:06:14 UTC) #2
axw
Please take a look.
10 years ago (2014-04-04 06:15:55 UTC) #3
axw
10 years ago (2014-04-04 06:22:55 UTC) #4
On 2014/04/04 04:06:14, wallyworld wrote:
> LGTM. I think thst one big test should / could be split up with a common
method
> to set stuff up, and then in each test a call to start instance for the
specific
> scenario being tested.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b