Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4446)

Issue 84280044: Always provide fake precise/amd64 tools

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by dave
Modified:
10 years ago
Reviewers:
mp+214160, thumper
Visibility:
Public.

Description

Always provide fake precise/amd64 tools Fake tools take their template from version.Current, which gets weird when the machine running the tests is nor amd64 or precise. This is an attempt to fix this and improves many of the failing provider tests on ppc64el. https://code.launchpad.net/~dave-cheney/juju-core/123-always-upload-fake-precise-amd64-tools/+merge/214160 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Always provide fake precise/amd64 tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M juju/testing/conn.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
dave_cheney.net
Please take a look.
10 years ago (2014-04-04 05:51:46 UTC) #1
dave_cheney.net
Please take a look.
10 years ago (2014-04-04 06:50:34 UTC) #2
dave_cheney.net
ping
10 years ago (2014-04-06 23:22:13 UTC) #3
thumper
10 years ago (2014-04-06 23:30:32 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b