Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5010)

Issue 8422043: state: give state backing its own file

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by rog
Modified:
11 years ago
Reviewers:
mp+157403, gz
Visibility:
Public.

Description

state: give state backing its own file The implementation is about to get bigger, and it's conceptually separate from the allWatcher itself. https://code.launchpad.net/~rogpeppe/juju-core/270-megawatcher-backing-new-file/+merge/157403 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: give state backing its own file #

Total comments: 1

Patch Set 3 : state: give state backing its own file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -147 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A state/megabacking.go View 1 chunk +154 lines, -0 lines 0 comments Download
M state/megawatcher.go View 2 chunks +0 lines, -147 lines 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
11 years ago (2013-04-05 15:16:06 UTC) #1
gz
LGTM https://codereview.appspot.com/8422043/diff/2001/state/megabacking.go File state/megabacking.go (right): https://codereview.appspot.com/8422043/diff/2001/state/megabacking.go#newcode1 state/megabacking.go:1: package state Would a top comment here roughly ...
11 years ago (2013-04-05 15:21:41 UTC) #2
rog
On 2013/04/05 15:21:41, gz wrote: > LGTM > > https://codereview.appspot.com/8422043/diff/2001/state/megabacking.go > File state/megabacking.go (right): > ...
11 years ago (2013-04-05 15:25:02 UTC) #3
rog
11 years ago (2013-04-05 15:26:13 UTC) #4
*** Submitted:

state: give state backing its own file

The implementation is about to get
bigger, and it's conceptually separate
from the allWatcher itself.

R=gz
CC=
https://codereview.appspot.com/8422043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b