Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3805)

Issue 84210043: Fix architecture name for armhf.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by jason.hobbs
Modified:
10 years, 1 month ago
Reviewers:
mp+214115, natefinch
Visibility:
Public.

Description

Fix architecture name for armhf. juju-tools for arm 32-bit all use "armhf" as the arch name; juju-core should use it too, rather than "arm". https://code.launchpad.net/~jason-hobbs/juju-core/1.18/+merge/214115 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -40 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/plugins/juju-metadata/toolsmetadata_test.go View 1 chunk +1 line, -1 line 0 comments Download
M constraints/constraints_test.go View 3 chunks +4 lines, -4 lines 0 comments Download
M container/kvm/kvm_test.go View 2 chunks +4 lines, -4 lines 0 comments Download
M environs/instances/instancetype_test.go View 7 chunks +13 lines, -13 lines 0 comments Download
M environs/manual/init_test.go View 5 chunks +5 lines, -5 lines 0 comments Download
M environs/testing/tools.go View 1 chunk +1 line, -1 line 0 comments Download
M instance/instance_test.go View 3 chunks +4 lines, -4 lines 0 comments Download
M juju/arch/arch.go View 2 chunks +2 lines, -2 lines 0 comments Download
M juju/arch/arch_test.go View 1 chunk +3 lines, -2 lines 0 comments Download
M provider/joyent/environ.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/joyent/provider.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/params/params_test.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
jason.hobbs
Please take a look.
10 years, 1 month ago (2014-04-03 20:47:14 UTC) #1
natefinch
10 years, 1 month ago (2014-04-03 20:50:47 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b