trivial: worker.ErrDead -> ErrTerminateAgent

trivial: worker.ErrDead -> ErrTerminateAgent

Trivial change to rename all occurences of
worker.ErrDead to worker.ErrTerminateAgent,
so it's closer to the actual meaning of it
(process returning 0, so upstart won't restart it).

https://code.launchpad.net/~dimitern/juju-core/024-rename-worker-errdead-to-errterminateagent/+merge/157364

(do not edit description out of merge proposal)

[dimitern, 2013-04-05 13:49:16]

Please take a look.

[fwereade, 2013-04-05 14:00:36]

LGTM trivial with the below tweaks

https://codereview.appspot.com/8416043/diff/1/worker/environ.go
File worker/environ.go (right):

https://codereview.appspot.com/8416043/diff/1/worker/environ.go#newcode12
worker/environ.go:12: var ErrTerminateAgent = errors.New("agent entity is
terminating")
s/is terminating/must be terminated/

https://codereview.appspot.com/8416043/diff/1/worker/uniter/uniter_test.go
File worker/uniter/uniter_test.go (right):

https://codereview.appspot.com/8416043/diff/1/worker/uniter/uniter_test.go#ne...
worker/uniter/uniter_test.go:1056: // the uniter and check that it/ fails as
expected when starting up; this
s|it/|it|

[dimitern, 2013-04-05 14:19:11]

*** Submitted:

trivial: worker.ErrDead -> ErrTerminateAgent

Trivial change to rename all occurences of
worker.ErrDead to worker.ErrTerminateAgent,
so it's closer to the actual meaning of it
(process returning 0, so upstart won't restart it).

R=fwereade
CC=
https://codereview.appspot.com/8416043

https://codereview.appspot.com/8416043/diff/1/worker/environ.go
File worker/environ.go (right):

https://codereview.appspot.com/8416043/diff/1/worker/environ.go#newcode12
worker/environ.go:12: var ErrTerminateAgent = errors.New("agent entity is
terminating")
On 2013/04/05 14:00:36, fwereade wrote:
> s/is terminating/must be terminated/

Done.

https://codereview.appspot.com/8416043/diff/1/worker/uniter/uniter_test.go
File worker/uniter/uniter_test.go (right):

https://codereview.appspot.com/8416043/diff/1/worker/uniter/uniter_test.go#ne...
worker/uniter/uniter_test.go:1056: // the uniter and check that it/ fails as
expected when starting up; this
On 2013/04/05 14:00:36, fwereade wrote:
> s|it/|it|

Done.

[rog, 2013-04-05 15:07:02]

LGTM but one trivial, which you might consider for the next branch. We're really
saying that the agent should terminate, not that the entity is terminating
(otherwise ErrDead would still be ok)

https://codereview.appspot.com/8416043/diff/1/worker/environ.go
File worker/environ.go (right):

https://codereview.appspot.com/8416043/diff/1/worker/environ.go#newcode12
worker/environ.go:12: var ErrTerminateAgent = errors.New("agent entity is
terminating")
"agent should terminate" ?

[dimitern, 2013-04-05 15:31:10]

On 2013/04/05 15:07:02, rog wrote:
> LGTM but one trivial, which you might consider for the next branch. We're
really
> saying that the agent should terminate, not that the entity is terminating
> (otherwise ErrDead would still be ok)
> 
> https://codereview.appspot.com/8416043/diff/1/worker/environ.go
> File worker/environ.go (right):
> 
> https://codereview.appspot.com/8416043/diff/1/worker/environ.go#newcode12
> worker/environ.go:12: var ErrTerminateAgent = errors.New("agent entity is
> terminating")
> "agent should terminate" ?

Cheers, I'll change it in the next CL.