Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1402)

Issue 8412043: Style the tab content in charm details UI.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rharding
Modified:
11 years, 1 month ago
Reviewers:
curtis, mp+157353
Visibility:
Public.

Description

Style the tab content in charm details UI. - Submitted for Huw. - Adjust html/CSS for styling. No functionality changed. https://code.launchpad.net/~rharding/juju-gui/tabs/+merge/157353 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Style the tab content in charm details UI. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -107 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/images/quality_cross_icon.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/quality_tick_icon.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 chunk +71 lines, -60 lines 0 comments Download
M app/subapps/browser/templates/browser_qa.handlebars View 1 chunk +3 lines, -3 lines 0 comments Download
M app/subapps/browser/views/charm.js View 3 chunks +7 lines, -5 lines 0 comments Download
M app/templates/browser-search.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M lib/views/browser/charm-full.less View 5 chunks +134 lines, -31 lines 0 comments Download
M lib/views/browser/main.less View 1 chunk +20 lines, -0 lines 0 comments Download
M lib/views/stylesheet.less View 1 chunk +1 line, -0 lines 0 comments Download
M test/test_browser_charm_details.js View 4 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
11 years, 1 month ago (2013-04-05 13:20:41 UTC) #1
rharding
LGTM - in qa noticed and filed bug #1164987. Added a card to the board ...
11 years, 1 month ago (2013-04-05 13:41:02 UTC) #2
curtis
Thank you Huw and Rick. LGTM. https://codereview.appspot.com/8412043/diff/1/app/subapps/browser/templates/browser_charm.handlebars File app/subapps/browser/templates/browser_charm.handlebars (right): https://codereview.appspot.com/8412043/diff/1/app/subapps/browser/templates/browser_charm.handlebars#newcode142 app/subapps/browser/templates/browser_charm.handlebars:142: </dt> Canonical/Ubuntu style ...
11 years, 1 month ago (2013-04-05 15:50:00 UTC) #3
rharding
11 years, 1 month ago (2013-04-05 16:15:08 UTC) #4
*** Submitted:

Style the tab content in charm details UI.

- Submitted for Huw.
- Adjust html/CSS for styling. No functionality changed.

R=curtis
CC=
https://codereview.appspot.com/8412043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b