Issue 84100043: code review 84100043: runtime: fix off-by-one in first frame in runtime.Stack

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84100043: code review 84100043: runtime: fix off-by-one in first frame in runtime.Stack

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by rsc

Modified:
9 years, 4 months ago

Reviewers:

CC:
golang-codereviews, iant

Visibility:
Public.

Description

runtime: fix off-by-one in first frame in runtime.Stack Need to use a PC inside the call instruction, not the return address. Fixes issue 7690.

Patch Set 1 #

Patch Set 2 : diff -r 4ca10cc10176 https://code.google.com/p/go/ #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	src/pkg/runtime/mprof.goc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/runtime/stack_test.go	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years ago (2014-04-03 15:14:53 UTC) #1

iant

What about the other cases where getcallerpc is passed to traceback (runtime·tracealloc, runtime·tracefree, GoroutineProfile)?

10 years ago (2014-04-03 16:32:56 UTC) #2

gobot

9 years, 4 months ago (2014-12-19 05:18:38 UTC) #3

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/84100043 is best) in the description in your
new CL.

Thanks very much.

Expand All Messages | Collapse All Messages