Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1174)

Issue 84100043: code review 84100043: runtime: fix off-by-one in first frame in runtime.Stack

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by rsc
Modified:
7 years, 1 month ago
Reviewers:
CC:
golang-codereviews, iant
Visibility:
Public.

Description

runtime: fix off-by-one in first frame in runtime.Stack Need to use a PC inside the call instruction, not the return address. Fixes issue 7690.

Patch Set 1 #

Patch Set 2 : diff -r 4ca10cc10176 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/pkg/runtime/mprof.goc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/stack_test.go View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
7 years, 9 months ago (2014-04-03 15:14:53 UTC) #1
iant
What about the other cases where getcallerpc is passed to traceback (runtime·tracealloc, runtime·tracefree, GoroutineProfile)?
7 years, 9 months ago (2014-04-03 16:32:56 UTC) #2
gobot
7 years, 1 month ago (2014-12-19 05:18:38 UTC) #3
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/84100043 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b