Issue 8406044: Add remaining go watcher attributes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8406044: Add remaining go watcher attributes.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by frankban

Modified:
11 years, 1 month ago

Reviewers:
bac, teknico, mp+157328

Visibility:
Public.

Description

Add remaining go watcher attributes. Added open ports to units and endpoints to relations. Removed the unused and confusing machine.instance_state. Will follow up with a branch fixing the way relation keys are generated by add_relation in the Go environment. https://code.launchpad.net/~frankban/juju-gui/bug-1164565-missing-delta/+merge/157328 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add remaining go watcher attributes. #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+195 lines, -33 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/handlers.js	View	1	5 chunks	+46 lines, -9 lines	0 comments	Download
M	app/models/models.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	app/store/env/fakebackend.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	app/store/env/sandbox.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	app/templates/unit.handlebars	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	test/test_fakebackend.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	test/test_model_handlers.js	View		6 chunks	+144 lines, -9 lines	0 comments	Download
M	test/test_sandbox.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	test/test_unit_view.js	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

teknico

LGTM, very nice. Thanks for fixing the juju-core relation id handling.

11 years, 1 month ago (2013-04-05 11:28:47 UTC) #2

frankban

*** Submitted: Add remaining go watcher attributes. Added open ports to units and endpoints to ...

11 years, 1 month ago (2013-04-05 14:26:06 UTC) #4

Nicola, Brad, thanks for the reviews!

Expand All Messages | Collapse All Messages