Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1890)

Issue 83880044: Add support for the Joyent provider.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by frankban
Modified:
10 years, 1 month ago
Reviewers:
bac, mp+214022
Visibility:
Public.

Description

Add support for the Joyent provider. Tests: `make check`. QA: QA is not straightforward for this branch, due to the fact this needs to be tested on a not yet released juju-core. Sorry about that. 1) Check out the 1.18 juju-core branch (lp:juju-core/1.18), and compile it. 2) Edit the quickstart/settings.py file included in this branch: set `JUJU_CMD` to point to the juju 1.18 path. 3) Sign up for a Joyent account from http://www.joyent.com/. 4) Run `.venv/bin/python juju-quickstart -i` and create a new joyent environment: DO NOT bootstrap it from quickstart, just create it and exit (^X). 5) Use juju 1.18 to bootstrap the joyent account, e.g. `juju bootstrap -e joyent --upload-tools`. This is required because quickstart does not support uploading tools. 6) After a minute, and while the environment is bootstrapping, open another terminal and re-run quickstart, select the joyent account you created and hit "use" (or just invoke quickstart with `-e joyent`). 7) Ensure everything proceeds as expected, and wait until the quickstart opens the GUI. Done, destroy the environment, thank you! https://code.launchpad.net/~frankban/juju-quickstart/joyent/+merge/214022 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add support for the Joyent provider. #

Patch Set 3 : Add support for the Joyent provider. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -1 line) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/models/envs.py View 1 2 3 chunks +60 lines, -1 line 0 comments Download
M quickstart/models/fields.py View 1 2 chunks +19 lines, -0 lines 0 comments Download
M quickstart/tests/models/test_envs.py View 2 chunks +16 lines, -0 lines 0 comments Download
M quickstart/tests/models/test_fields.py View 1 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 10
frankban
Please take a look.
10 years, 1 month ago (2014-04-03 13:20:57 UTC) #1
bac
Code LGTM. On to QA. https://codereview.appspot.com/83880044/diff/1/quickstart/tests/models/test_fields.py File quickstart/tests/models/test_fields.py (right): https://codereview.appspot.com/83880044/diff/1/quickstart/tests/models/test_fields.py#newcode468 quickstart/tests/models/test_fields.py:468: field.validate(unicode(__file__)) Nice use of ...
10 years, 1 month ago (2014-04-03 15:20:54 UTC) #2
bac
When doing QA and bootstrapping the joyent environment I get http://paste.ubuntu.com/7199671/ https://codereview.appspot.com/83880044/diff/1/quickstart/models/envs.py File quickstart/models/envs.py (right): ...
10 years, 1 month ago (2014-04-03 17:23:49 UTC) #3
bac
For the private key file path, the default is listed as ~/.ssh/id_rsa If you try ...
10 years, 1 month ago (2014-04-03 20:06:11 UTC) #4
bac
QA-OK after lots of struggles, mainly the issue with passphrase-protected ssh key, which is not ...
10 years, 1 month ago (2014-04-03 20:22:37 UTC) #5
frankban
On 2014/04/03 20:06:11, bac wrote: > For the private key file path, the default is ...
10 years, 1 month ago (2014-04-04 08:07:54 UTC) #6
frankban
On 2014/04/03 20:22:37, bac wrote: > QA-OK after lots of struggles, mainly the issue with ...
10 years, 1 month ago (2014-04-04 08:10:05 UTC) #7
frankban
Please take a look. https://codereview.appspot.com/83880044/diff/1/quickstart/models/envs.py File quickstart/models/envs.py (right): https://codereview.appspot.com/83880044/diff/1/quickstart/models/envs.py#newcode621 quickstart/models/envs.py:621: 'manta-user', required=True, On 2014/04/03 17:23:50, ...
10 years, 1 month ago (2014-04-04 08:11:26 UTC) #8
bac
Changes all LGTM. Thanks.
10 years, 1 month ago (2014-04-04 12:19:49 UTC) #9
frankban
10 years, 1 month ago (2014-04-10 09:39:03 UTC) #10
*** Submitted:

Add support for the Joyent provider.

Tests: `make check`.

QA:
QA is not straightforward for this branch, due to the
fact this needs to be tested on a not yet released
juju-core. Sorry about that.
1) Check out the 1.18 juju-core branch (lp:juju-core/1.18), 
   and compile it.
2) Edit the quickstart/settings.py file included in this branch:
   set `JUJU_CMD` to point to the juju 1.18 path.
3) Sign up for a Joyent account from http://www.joyent.com/.
4) Run `.venv/bin/python juju-quickstart -i` and create a new
   joyent environment: DO NOT bootstrap it from quickstart, just
   create it and exit (^X).
5) Use juju 1.18 to bootstrap the joyent account, e.g.
   `juju bootstrap -e joyent --upload-tools`. This is required
   because quickstart does not support uploading tools.
6) After a minute, and while the environment is bootstrapping,
   open another terminal and re-run quickstart, select the
   joyent account you created and hit "use" 
   (or just invoke quickstart with `-e joyent`).
7) Ensure everything proceeds as expected, and wait
   until the quickstart opens the GUI.
Done, destroy the environment, thank you!

R=bac
CC=
https://codereview.appspot.com/83880044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b