Provide hidden options for proof server.

Provide hidden options for proof server.

When doing QA for charmworld bundle proof changes to ensure they work with
charm-proof, it is troublesome to get charm-proof pointed at a local
charmworld instance or the one at staging.jujucharms.com.

This branch adds three new command-line option: --server, --port, and
--secure.

A typical use is:

% charm-proof -b --server=localhost --port=2464 -b .

or

% charm-proof -b --server=staging.jujucharms.com -b .

Note that 'help=argparse.SUPPRESS' has been used so that 'charm-proof -h' does
not show these options to the regular user.  I think suppressing their
existence strikes the right balance between having options that only serve
developers while preserving the clean CLI for the average user.

https://code.launchpad.net/~bac/charm-tools/cmd-line-server/+merge/213926

(do not edit description out of merge proposal)

[bac, 2014-04-02 21:03:06]

Please take a look.

[Marco Ceppi, 2014-04-08 00:26:26]

Thanks a lot for these fixes, they add additional flexibility to the proof
command!

I had just a few minor questions, really curiosities. Outside of that this
LGTM!!!

https://codereview.appspot.com/83700043/diff/1/charmtools/bundles.py
File charmtools/bundles.py (right):

https://codereview.appspot.com/83700043/diff/1/charmtools/bundles.py#newcode57
charmtools/bundles.py:57: def remote_proof(self, bundle, server, port, secure):
Since server, port, and secure are optional why not just set them to None as
kwargs?

https://codereview.appspot.com/83700043/diff/1/charmtools/proof.py
File charmtools/proof.py (left):

https://codereview.appspot.com/83700043/diff/1/charmtools/proof.py#oldcode40
charmtools/proof.py:40: def proof(path, is_bundle=False, with_remote=True,
debug=False):
Why were defaults removed?

[bac, 2014-04-08 14:31:32]

Thanks for the review Marco.  I think getting this merged will be a win for us.

https://codereview.appspot.com/83700043/diff/1/charmtools/bundles.py
File charmtools/bundles.py (right):

https://codereview.appspot.com/83700043/diff/1/charmtools/bundles.py#newcode57
charmtools/bundles.py:57: def remote_proof(self, bundle, server, port, secure):
On 2014/04/08 00:26:26, Marco Ceppi wrote:
> Since server, port, and secure are optional why not just set them to None as
> kwargs?

proof is the only call site and the default values are set there so in order to
not repeat myself I only had the defaults at the external entry point.

https://codereview.appspot.com/83700043/diff/1/charmtools/proof.py
File charmtools/proof.py (left):

https://codereview.appspot.com/83700043/diff/1/charmtools/proof.py#oldcode40
charmtools/proof.py:40: def proof(path, is_bundle=False, with_remote=True,
debug=False):
The single call site provides the arguments from the arg parser.  When setting
up the argparser we provide the default values.  So it seemed redundant to me to
have the defaults set in two places.

[bac, 2014-04-08 21:26:44]

*** Submitted:

Provide hidden options for proof server.

When doing QA for charmworld bundle proof changes to ensure they work with
charm-proof, it is troublesome to get charm-proof pointed at a local
charmworld instance or the one at staging.jujucharms.com.

This branch adds three new command-line option: --server, --port, and
--secure.

A typical use is:

% charm-proof -b --server=localhost --port=2464 -b .

or

% charm-proof -b --server=staging.jujucharms.com -b .

Note that 'help=argparse.SUPPRESS' has been used so that 'charm-proof -h' does
not show these options to the regular user.  I think suppressing their
existence strikes the right balance between having options that only serve
developers while preserving the clean CLI for the average user.

R=Marco Ceppi
CC=
https://codereview.appspot.com/83700043