Issue 8366046: .lbox: add a go build check to .lbox.check

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8366046: .lbox: add a go build check to .lbox.check (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by dave

Modified:
11 years, 1 month ago

Reviewers:
mp+157271

Visibility:
Public.

Description

.lbox: add a go build check to .lbox.check https://code.launchpad.net/~dave-cheney/juju-core/111-add-go-build-check-to-lbox/+merge/157271 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : .lbox: add a go build check to .lbox.check #

Patch Set 3 : .lbox: add a go build check to .lbox.check #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	.lbox.check	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2013/04/05 04:47:40, dfc wrote: > Please take a look. Sorry, diff is dirty.

11 years, 1 month ago (2013-04-05 04:48:38 UTC) #2

fwereade

On 2013/04/05 07:11:48, fwereade wrote: > retroactive LGTM trivial Whoops, not retroactive, that was the ...

11 years, 1 month ago (2013-04-05 07:13:13 UTC) #4

dave_cheney.net

11 years, 1 month ago (2013-04-05 07:19:32 UTC) #6

*** Submitted:

.lbox: add a go build check to .lbox.check

R=fwereade
CC=
https://codereview.appspot.com/8366046

Expand All Messages | Collapse All Messages