Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(112)

Issue 8364044: Fix bug in charm load handler.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by bac
Modified:
10 years, 12 months ago
Reviewers:
rharding, jeff.pihach, mp+157197
Visibility:
Public.

Description

Fix bug in charm load handler. https://code.launchpad.net/~bac/juju-gui/fix-goof/+merge/157197 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix bug in charm load handler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/endpoints.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_endpoints.js View 1 2 chunks +40 lines, -1 line 0 comments Download

Messages

Total messages: 4
bac
Please take a look.
10 years, 12 months ago (2013-04-04 18:38:15 UTC) #1
jeff.pihach
LGTM with comment below. Thanks for the quick fix! https://codereview.appspot.com/8364044/diff/1/test/test_endpoints.js File test/test_endpoints.js (right): https://codereview.appspot.com/8364044/diff/1/test/test_endpoints.js#newcode430 test/test_endpoints.js:430: ...
10 years, 12 months ago (2013-04-04 18:41:02 UTC) #2
rharding
LGTM with Jeff's cleanup comment.
10 years, 12 months ago (2013-04-04 18:48:42 UTC) #3
bac
10 years, 12 months ago (2013-04-04 19:09:53 UTC) #4
*** Submitted:

Fix bug in charm load handler.

R=jeff.pihach, rharding
CC=
https://codereview.appspot.com/8364044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b