Issue 8364043: worker/uniter: increase worst case timeouts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8364043: worker/uniter: increase worst case timeouts

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rog

Modified:
11 years, 1 month ago

Reviewers:
mp+157097, fwereade, dimitern

Visibility:
Public.

Description

worker/uniter: increase worst case timeouts This is necessary to get the uniter tests to pass under the race detector. https://code.launchpad.net/~rogpeppe/juju-core/267-uniter-longer-timeouts/+merge/157097 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : worker/uniter: increase worst case timeouts #

Total comments: 2

Patch Set 3 : worker/uniter: increase worst case timeouts #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -8 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/watcher/watcher_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	worker/uniter/relationer_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	worker/uniter/uniter_test.go	View	1 2	7 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

Nice, LGTM! https://codereview.appspot.com/8364043/diff/2001/worker/uniter/uniter_test.go File worker/uniter/uniter_test.go (right): https://codereview.appspot.com/8364043/diff/2001/worker/uniter/uniter_test.go#newcode32 worker/uniter/uniter_test.go:32: const worstCase = 30 * time.Second doc ...

11 years, 1 month ago (2013-04-04 14:29:39 UTC) #2

rog

11 years, 1 month ago (2013-04-05 13:24:54 UTC) #4

*** Submitted:

worker/uniter: increase worst case timeouts

This is necessary to get the uniter tests to pass
under the race detector.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/8364043

https://codereview.appspot.com/8364043/diff/2001/worker/uniter/uniter_test.go
File worker/uniter/uniter_test.go (right):

https://codereview.appspot.com/8364043/diff/2001/worker/uniter/uniter_test.go...
worker/uniter/uniter_test.go:32: const worstCase = 30 * time.Second
On 2013/04/04 14:29:39, dimitern wrote:
> doc comment please, like in the watcher

Done.

Expand All Messages | Collapse All Messages