Issue 8363043: Fixes #1164002 browser add button display.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8363043: Fixes #1164002 browser add button display.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rharding

Modified:
11 years ago

Reviewers:
mp+157096, jeff.pihach

Visibility:
Public.

Description

Fixes #1164002 browser add button display. - Adjust the add button to work properly in OSX Chrome - Adjust the add button to work properly in FF nightly - Fixes color and tiling of the background image. https://code.launchpad.net/~rharding/juju-gui/fix_add_button/+merge/157096 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes #1164002 browser add button display. #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -10 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/assets/images/browser_add_button_centre.jpg	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/subapps/browser/views/charm.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/views/browser/charm-full.less	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	test/test_browser_charm_details.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rharding

11 years ago (2013-04-04 15:25:41 UTC) #4

*** Submitted:

Fixes #1164002 browser add button display.

- Adjust the add button to work properly in OSX Chrome
- Adjust the add button to work properly in FF nightly
- Fixes color and tiling of the background image.

R=jeff.pihach
CC=
https://codereview.appspot.com/8363043

Expand All Messages | Collapse All Messages