Issue 8362048: Keep touch events from colliding

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8362048: Keep touch events from colliding

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by matthew.scott

Modified:
11 years ago

Reviewers:
mp+157757, gary.poster

Visibility:
Public.

Description

Keep touch events from colliding Taps were being interpreted as drags as well as clicks, and services were being moved due to the way that touch events were being handled. In order to clean this up, dragging now takes place with two (or more) fingers, and clicking with one finger. Additionally, tap-to-click was toggling the service menu twice, and that is now being prevented. This applies to Ubuntu Touch devices and causes trouble for some Android devices (bug #1167005) https://code.launchpad.net/~makyo/juju-gui/touch-moves-1159870/+merge/157757 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -5 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/topology/service.js	View		4 chunks	+29 lines, -5 lines	0 comments	Download
M	test/test_service_module.js	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gary.poster

awesome, thank you. Will qa next, since I'm the only other person who can :-P. ...

11 years ago (2013-04-09 14:38:46 UTC) #2

rharding

QA Result: Nexus 10 latest android. Clicking on a charm no longer works in Chrome ...

11 years ago (2013-04-09 15:41:29 UTC) #3

gary.poster

LGTM, acknowledging the fact that it did not qa on the other tablet as we ...

11 years ago (2013-04-09 16:00:20 UTC) #4

matthew.scott

11 years ago (2013-04-09 21:47:12 UTC) #5

*** Submitted:

Keep touch events from colliding

Taps were being interpreted as drags as well as clicks, and services were being
moved due to the way that touch events were being handled. In order to clean
this up, dragging now takes place with two (or more) fingers, and clicking with
one finger.  Additionally, tap-to-click was toggling the service menu twice, and
that is now being prevented.  This applies to Ubuntu Touch devices and causes
trouble for some Android devices (bug #1167005)

R=gary.poster, rharding
CC=
https://codereview.appspot.com/8362048

Expand All Messages | Collapse All Messages