Issue 8362046: code review 8362046: runtime: change Note from union to struct

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8362046: code review 8362046: runtime: change Note from union to struct (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by dvyukov

Modified:
12 years, 8 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

runtime: change Note from union to struct Unions can break precise GC. Update issue 5193.

Patch Set 1 #

Patch Set 2 : diff -r 7767d71dcc7b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 7767d71dcc7b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 7767d71dcc7b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 915504d8aa44 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -20 lines)			Patch
M	src/pkg/runtime/lock_futex.c	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	src/pkg/runtime/lock_sema.c	View	1 2	5 chunks	+9 lines, -9 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 2 3 4	2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 8 months ago (2013-04-07 02:15:53 UTC) #1

dvyukov

12 years, 8 months ago (2013-04-07 03:09:07 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4f3dd44f3eb2 ***

runtime: change Note from union to struct
Unions can break precise GC.
Update issue 5193.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/8362046

Expand All Messages | Collapse All Messages