code review 83580046: go.tools/cmd/godex: update documentation

go.tools/cmd/godex: update documentation

[gri, 2014-04-02 21:21:32]

Hello adonovan@google.com (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[adonovan, 2014-04-02 21:37:56]

LGTM

https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go
File cmd/godex/doc.go (right):

https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go#newcode28
cmd/godex/doc.go:28: // build os and architecture specific directory names from
the path).
"build OS- and architecture-specific directory names"

https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go#newcode30
cmd/godex/doc.go:30: // "foo", a package "a/foo" is found before "b/foo".
If I specify "go/types", and there also exists a package "a/go/types", which
will be used?  i.e. does the search only happen if there is no exact match?  I
would expect so, butthis paragraph doesn't make it explicit.

[gri, 2014-04-02 21:42:08]

https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go
File cmd/godex/doc.go (right):

https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go#newcode28
cmd/godex/doc.go:28: // build os and architecture specific directory names from
the path).
On 2014/04/02 21:37:57, adonovan wrote:
> "build OS- and architecture-specific directory names"

Done.

https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go#newcode30
cmd/godex/doc.go:30: // "foo", a package "a/foo" is found before "b/foo".
On 2014/04/02 21:37:57, adonovan wrote:
> If I specify "go/types", and there also exists a package "a/go/types", which
> will be used?  i.e. does the search only happen if there is no exact match?  I
> would expect so, butthis paragraph doesn't make it explicit.

It says before, "if only a partial package path is given" - that is, only if the
exact match does not work. In practice, this is done by trying the empty prefix
first.

[adonovan, 2014-04-02 21:44:43]

https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go
File cmd/godex/doc.go (right):

https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go#newcode30
cmd/godex/doc.go:30: // "foo", a package "a/foo" is found before "b/foo".
On 2014/04/02 21:42:08, gri wrote:
> On 2014/04/02 21:37:57, adonovan wrote:
> > If I specify "go/types", and there also exists a package "a/go/types", which
> > will be used?  i.e. does the search only happen if there is no exact match? 
I
> > would expect so, butthis paragraph doesn't make it explicit.
> 
> It says before, "if only a partial package path is given" - that is, only if
the
> exact match does not work. In practice, this is done by trying the empty
prefix
> first.

Fair enough.

[gri, 2014-04-07 20:49:14]

*** Submitted as
https://code.google.com/p/go/source/detail?r=0d756285d6c0&repo=tools ***

go.tools/cmd/godex: update documentation

LGTM=adonovan
R=adonovan
CC=golang-codereviews
https://codereview.appspot.com/83580046