Enable BrowserCharmView to render in sidebar too.

Enable BrowserCharmView to render in sidebar too.

- Step #1 to getting the sidebar working. Followups will hook into clicking on
charms to open. Currently only direct url-able.
- Pull shared code to the MainView
- Adjust the sidebar render to render BrowserCharmView when you hit direct
urls for it
- Add the routes/callables for the /sidebar/charmid

https://code.launchpad.net/~rharding/juju-gui/charm_sidebar/+merge/157198

(do not edit description out of merge proposal)

[rharding, 2013-04-04 18:39:31]

Please take a look.

[jeff.pihach, 2013-04-04 18:54:25]

LGTM one question below that if it's covered then good to land.

https://codereview.appspot.com/8356044/diff/1/app/subapps/browser/views/view.js
File app/subapps/browser/views/view.js (right):

https://codereview.appspot.com/8356044/diff/1/app/subapps/browser/views/view....
app/subapps/browser/views/view.js:107: var charmView = new ns.BrowserCharmView({
Is there a procedure in place somewhere else which handles triggering the
destroy method on this view?

[rharding, 2013-04-04 18:56:32]

Reply below.

https://codereview.appspot.com/8356044/diff/1/app/subapps/browser/views/view.js
File app/subapps/browser/views/view.js (right):

https://codereview.appspot.com/8356044/diff/1/app/subapps/browser/views/view....
app/subapps/browser/views/view.js:107: var charmView = new ns.BrowserCharmView({
On 2013/04/04 18:54:25, jeff.pihach wrote:
> Is there a procedure in place somewhere else which handles triggering the
> destroy method on this view?

Not currently. You can only load the view by manual url redirection and clicking
to another view will get this one destroyed as part of the process of routing
away.

The next branch will enable opening this view over and over based on the charm
token you've clicked on in the sidebar. Since you might run down the sidebar
clicking on 10 different ones for details, the event handling there will
maintain state and destroy/create new views as required.

[bac, 2013-04-04 19:06:20]

LGTM with trivial changes.  Thanks Rick.

https://codereview.appspot.com/8356044/diff/1/app/subapps/browser/browser.js
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/8356044/diff/1/app/subapps/browser/browser.js#...
app/subapps/browser/browser.js:150: *
I think yuidoc may get pissy if there isn't a @return

https://codereview.appspot.com/8356044/diff/1/app/subapps/browser/views/view.js
File app/subapps/browser/views/view.js (right):

https://codereview.appspot.com/8356044/diff/1/app/subapps/browser/views/view....
app/subapps/browser/views/view.js:91: *
@return?

[rharding, 2013-04-04 19:20:09]

*** Submitted:

Enable BrowserCharmView to render in sidebar too.

- Step #1 to getting the sidebar working. Followups will hook into clicking on
charms to open. Currently only direct url-able.
- Pull shared code to the MainView
- Adjust the sidebar render to render BrowserCharmView when you hit direct
urls for it
- Add the routes/callables for the /sidebar/charmid

R=jeff.pihach, bac
CC=
https://codereview.appspot.com/8356044