provider/joyent: key-file => private-key-path

provider/joyent: key-file => private-key-path

This only loosely depends on the nil-key-file patch (just because
otherwise they conflict, and I wanted it to be easy to land.)

This is a backwards incompatible change, so I wanted to land it early
before we have Joyent in an official release.

Doing this change makes the config fit how we do those settings
elsewhere (ca-cert-path vs ca-cert, etc). It also avoids using the name
"key-file" which is easier for us developers, since keyFile is a term
we use WRT MongoDB which means something entirely different.

https://code.launchpad.net/~jameinel/juju-core/1.18-private-key-path-1301315/+merge/213818

Requires: https://code.launchpad.net/~jameinel/juju-core/1.18-nil-key-file-1300846/+merge/213805

(do not edit description out of merge proposal)

[jameinel, 2014-04-02 11:31:13]

Please take a look.

[wallyworld, 2014-04-02 12:04:58]

LGTM with comment fix

https://codereview.appspot.com/83530044/diff/1/provider/joyent/config.go
File provider/joyent/config.go (right):

https://codereview.appspot.com/83530044/diff/1/provider/joyent/config.go#newc...
provider/joyent/config.go:42: # You can also "private-key" to the *content* of
the private key, instead.
Wording seems a little off?

[jameinel, 2014-04-02 12:35:17]

Please take a look.

https://codereview.appspot.com/83530044/diff/1/provider/joyent/config.go
File provider/joyent/config.go (right):

https://codereview.appspot.com/83530044/diff/1/provider/joyent/config.go#newc...
provider/joyent/config.go:42: # You can also "private-key" to the *content* of
the private key, instead.
On 2014/04/02 12:04:58, wallyworld wrote:
> Wording seems a little off?

Done.