code review 8350044: misc/dist: don't ship race-enabled commands

misc/dist: don't ship race-enabled commands

[adg, 2013-04-04 01:04:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-04-04 01:06:58]

LGTM
 On Apr 3, 2013 6:04 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> misc/dist: don't ship race-enabled commands
>
> Please review this at
https://codereview.appspot.**com/8350044/<https://codereview.appspot.com/8350...
>
> Affected files:
>   M misc/dist/bindist.go
>
>
> Index: misc/dist/bindist.go
> ==============================**==============================**=======
> --- a/misc/dist/bindist.go
> +++ b/misc/dist/bindist.go
> @@ -197,6 +197,12 @@
>                 if err != nil {
>                         return err
>                 }
> +               // Re-install std without -race, so that we're not left
> with
> +               // a slower, race-enabled cmd/go, cmd/godoc, etc.
> +               _, err = b.run(src, goCmd, "install", "-a", "std")
> +               if err != nil {
> +                       return err
> +               }
>         }
>
>         if err := b.tour(); err != nil {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[adg, 2013-04-04 01:08:00]

*** Submitted as https://code.google.com/p/go/source/detail?r=3cadb95c63bd ***

misc/dist: don't ship race-enabled commands

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/8350044