Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(509)

Issue 8345046: Hook up JujuCore set-config in GUI.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by teknico
Modified:
10 years, 12 months ago
Reviewers:
jeff.pihach, mp+157149, matthew.scott
Visibility:
Public.

Description

Hook up JujuCore set-config in GUI. Implement set_config in the Go environment, with tests. Also add set_config tests to the Python environment too. https://code.launchpad.net/~teknico/juju-gui/hookup-set-config-in-go-env/+merge/157149 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Hook up JujuCore set-config in GUI. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/go.js View 1 chunk +56 lines, -0 lines 0 comments Download
M test/test_env_go.js View 2 chunks +49 lines, -1 line 0 comments Download
M test/test_env_python.js View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 4
teknico
Please take a look.
10 years, 12 months ago (2013-04-04 16:07:43 UTC) #1
jeff.pihach
LGTM Thanks!
10 years, 12 months ago (2013-04-04 16:18:27 UTC) #2
matthew.scott
LGTM - thanks for the tests!
10 years, 12 months ago (2013-04-04 16:24:19 UTC) #3
teknico
10 years, 12 months ago (2013-04-04 16:31:54 UTC) #4
*** Submitted:

Hook up JujuCore set-config in GUI.

Implement set_config in the Go environment, with tests.
Also add set_config tests to the Python environment too.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/8345046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b