Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 83430044: code review 83430044: cmd/gc: Don't zero more than we need. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by khr
Modified:
11 years, 7 months ago
Reviewers:
gobot, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

cmd/gc: Don't zero more than we need. Don't merge with the zero range, we may end up zeroing more than we need.

Patch Set 1 #

Patch Set 2 : diff -r dbf809235908 https://code.google.com/p/go/ #

Patch Set 3 : diff -r dbf809235908 https://code.google.com/p/go/ #

Patch Set 4 : diff -r dbf809235908 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 23cb4547ef55 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 23cb4547ef55 https://code.google.com/p/go/ #

Patch Set 7 : diff -r 23cb4547ef55 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/6g/ggen.c View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8g/ggen.c View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
khr
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 7 months ago (2014-04-02 16:05:31 UTC) #1
rsc
LGTM
11 years, 7 months ago (2014-04-02 16:09:25 UTC) #2
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=4ac99a6bfaa3 *** cmd/gc: Don't zero more than we need. Don't merge with ...
11 years, 7 months ago (2014-04-02 16:17:49 UTC) #3
gobot
11 years, 7 months ago (2014-04-02 16:28:29 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the windows-amd64-race builder.
See http://build.golang.org/log/7ef9a5c4af6550950888b8c8557bea6802234a54
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b