Added script to create and upload a stream

Added script to create and upload a stream

The script create_stream.bash is an utility that
creates and uploads a stream to a given server, using
the current jujud build.
This is useful when trying to reproduce production
envs with a dev version, without using --upload-tools,
which produces an env closer to reality

https://code.launchpad.net/~hduran-8/juju-core/add_create_stream_script/+merge/213749

(do not edit description out of merge proposal)

[hduran, 2014-04-02 00:35:14]

Please take a look.

[dave_cheney.net, 2014-04-02 00:42:10]

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash
File scripts/create_stream.bash (right):

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:1: #!/bin/bash
set -e

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:2: BUILD_FOLDER=/tmp/build_juju
should use mktemp

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:44: get_version ${control_version}-0ubuntu4
will the suffix always be -0ubuntu4 ?

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:49: echo "Please run install on jujud, it must be in
GOPATH/bin"
why not give them the command, go install launchpad.net/juju-core/cmd/jujud

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:55: ${GOPATH}/bin/jujud --version
echo "Packed version: $(${GOPATH}/bin/jujud --version)"

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:69: usage
what happens if the other two arguments aren't provided?

[hduran, 2014-04-02 00:42:51]

Please take a look.

[hduran, 2014-04-02 01:53:12]

Please take a look.

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash
File scripts/create_stream.bash (right):

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:1: #!/bin/bash
On 2014/04/02 00:42:10, dfc wrote:
> set -e

Done.

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:2: BUILD_FOLDER=/tmp/build_juju
On 2014/04/02 00:42:10, dfc wrote:
> should use mktemp

Done.

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:44: get_version ${control_version}-0ubuntu4
On 2014/04/02 00:42:10, dfc wrote:
> will the suffix always be -0ubuntu4 ?

That was trailing from the original script (this has been ripped from a few QA
scripts which created the stream from a .deb

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:44: get_version ${control_version}-0ubuntu4
On 2014/04/02 00:42:10, dfc wrote:
> will the suffix always be -0ubuntu4 ?

Done.

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:49: echo "Please run install on jujud, it must be in
GOPATH/bin"
On 2014/04/02 00:42:10, dfc wrote:
> why not give them the command, go install launchpad.net/juju-core/cmd/jujud

Done.

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:55: ${GOPATH}/bin/jujud --version
On 2014/04/02 00:42:10, dfc wrote:
> echo "Packed version: $(${GOPATH}/bin/jujud --version)"

Done.

https://codereview.appspot.com/83370043/diff/1/scripts/create_stream.bash#new...
scripts/create_stream.bash:69: usage
On 2014/04/02 00:42:10, dfc wrote:
> what happens if the other two arguments aren't provided?

There are default values set in lines 10 and 12

[fwereade, 2014-04-02 06:34:58]

So, --upload-tools surely sucks, and we shouldn't be using it... but I'm not
entirely convinced that what we have here is better.

NOT LGTM without a bit of discussion about what use case we're fulfilling and
whether this is really the right way to do it.

https://codereview.appspot.com/83370043/diff/40001/scripts/create_stream.bash
File scripts/create_stream.bash (right):

https://codereview.appspot.com/83370043/diff/40001/scripts/create_stream.bash...
scripts/create_stream.bash:14: : ${ARCH:="amd64"}
This *has* to be the arch of the local machine, doesn't it? I see no
cross-compilation...

https://codereview.appspot.com/83370043/diff/40001/scripts/create_stream.bash...
scripts/create_stream.bash:16: : ${TARGET_SERIES:="precise"}
TARGET_SERIES *surely* ought to default to the current local series -- that's
where it's been built, and where we can expect it to work. Assuming that
everything built everywhere will work on precise seems a touch optimistic...

https://codereview.appspot.com/83370043/diff/40001/scripts/create_stream.bash...
scripts/create_stream.bash:42: fi
I don't think it's a good idea to take the version from a source tree that
potentially bears no relation whatsoever to the binary we upload. Any reason not
to build jujud ourselves? (Please just make sure it's properly isolated -- don't
overwrite *anything* in the user's GOPATH.)

https://codereview.appspot.com/83370043/diff/40001/scripts/create_stream.bash...
scripts/create_stream.bash:48: JUJU_HOME=~/.juju PATH=$GOPATH/bin:$PATH \
why do we set a potentially-differing value for JUJU_HOME?

[curtis, 2014-04-03 00:57:13]

https://codereview.appspot.com/83370043/diff/40001/scripts/create_stream.bash
File scripts/create_stream.bash (right):

https://codereview.appspot.com/83370043/diff/40001/scripts/create_stream.bash...
scripts/create_stream.bash:14: : ${ARCH:="amd64"}
On 2014/04/02 06:34:58, fwereade wrote:
> This *has* to be the arch of the local machine, doesn't it? I see no
> cross-compilation...

Using local machine is better than hard-coding. Juju CI scavenges/repurposes the
jujud's built on the unit-test machines like the ppc64el. We exec commands over
ssh to get the characteristics of the build machine. I think we get most of what
we want by running "jujud version" which yields "1.17.7-trusty-amd64" on my
machine.

VERSION=$(jujud version | cut -d - -f1)
SERIES=$(jujud version | cut -d - -f2)
ARCH=$(jujud version | cut -d - -f3)


to get the version, series, and arch

https://codereview.appspot.com/83370043/diff/40001/scripts/create_stream.bash...
scripts/create_stream.bash:48: JUJU_HOME=~/.juju PATH=$GOPATH/bin:$PATH \
On 2014/04/02 06:34:58, fwereade wrote:
> why do we set a potentially-differing value for JUJU_HOME?

JUJU_HOME isn't doing anything in this case.

This is probably a transcription error from assemble-public-tools.bash. The
script is run on systems without a proper user, without .juju/, and sometimes
without an installed juju. In these cases, the script env is often sets
JUJU_HOME to cloud-city which has a vetted environments.yaml.