Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1373)

Issue 83340045: Workaround LP 1251076

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by dfc
Modified:
5 years, 10 months ago
Reviewers:
mp+213764, fwereade
Visibility:
Public.

Description

Workaround LP 1251076 gccgo appears to get confused and thinks that out[1] is not nil when in fact it is an interface value of type error and value nil. This workaround solves the problem by leaving error as nil if in fact it was nil and causes no harm for gc because the predicates above assert that if out[1] is not nil, then it is an error type. https://code.launchpad.net/~dave-cheney/juju-core/110-fix-lp-1251076/+merge/213764 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Workaround LP 1251076 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M rpc/rpcreflect/type.go View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 3
dfc
Please take a look.
5 years, 10 months ago (2014-04-02 04:58:32 UTC) #1
dfc
Please take a look.
5 years, 10 months ago (2014-04-02 05:01:14 UTC) #2
fwereade
5 years, 10 months ago (2014-04-02 07:20:15 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b