Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(257)

Issue 8333044: api samples Issue 762: Update samples to use central Maven repository (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by ngmiceli
Modified:
13 years, 2 months ago
Reviewers:
yanivi
Base URL:
https://code.google.com/p/google-api-java-client.samples/
Visibility:
Public.

Description

api samples Issue 762: Update samples to use central Maven repository

Patch Set 1 #

Patch Set 2 : Missed one #

Total comments: 2

Patch Set 3 : Merge & Fix Warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -173 lines) Patch
M adexchangebuyer-cmdline-sample/pom.xml View 1 2 2 chunks +1 line, -8 lines 0 comments Download
M adsense-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M adsensehost-cmdline-sample/pom.xml View 1 2 chunks +1 line, -8 lines 0 comments Download
M analytics-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M bigquery-appengine-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M books-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M calendar-appengine-sample/pom.xml View 2 chunks +1 line, -5 lines 0 comments Download
M calendar-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M compute-engine-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M dfareporting-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M discovery-cmdline-sample/pom.xml View 1 2 3 chunks +2 lines, -8 lines 0 comments Download
M drive-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M fusiontables-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M latitude-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M oauth2-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M plus-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M plus-serviceaccount-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M prediction-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M siteVerification-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M storage-serviceaccount-appengine-sample/pom.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M storage-serviceaccount-cmdline-sample/pom.xml View 1 chunk +0 lines, -7 lines 0 comments Download
M taskqueue-cmdline-sample/pom.xml View 2 chunks +1 line, -8 lines 0 comments Download
M urlshortener-robots-appengine-sample/pom.xml View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 5
ngmiceli
13 years, 2 months ago (2013-04-03 19:54:02 UTC) #1
yanivi
FYI I wrote a trivial little shell script to compile all of the samples: SAMPLE_DIR=~/hg/google-api-java-client/samples/review ...
13 years, 2 months ago (2013-04-04 14:30:36 UTC) #2
ngmiceli
13 years, 2 months ago (2013-04-04 14:47:55 UTC) #3
ngmiceli
https://codereview.appspot.com/8333044/diff/3001/discovery-cmdline-sample/pom.xml File discovery-cmdline-sample/pom.xml (right): https://codereview.appspot.com/8333044/diff/3001/discovery-cmdline-sample/pom.xml#newcode94 discovery-cmdline-sample/pom.xml:94: <artifactId>maven-compiler-plugin</artifactId> On 2013/04/04 14:30:36, yanivi wrote: > while here, ...
13 years, 2 months ago (2013-04-04 14:48:40 UTC) #4
yanivi
13 years, 2 months ago (2013-04-04 14:53:59 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b