code review 83330045: net: make WriteTo, WriteToUnix and WriteMsgUnix fail wh...

net: make WriteTo, WriteToUnix and WriteMsgUnix fail when connectionless-mode UnixConn is already connected

This CL tries to fill the gap between Linux and other Unix-like systems
in the same way UDPConn already did.

Fixes issue 7677.

[mikio, 2014-04-02 03:42:58]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-04-02 04:00:46]

LGTM

https://codereview.appspot.com/83330045/diff/40001/src/pkg/net/unix_test.go
File src/pkg/net/unix_test.go (right):

https://codereview.appspot.com/83330045/diff/40001/src/pkg/net/unix_test.go#n...
src/pkg/net/unix_test.go:183: if _, err =
c.(*UnixConn).WriteTo([]byte("Connection-oriented mode socket"), raddr); err ==
nil {
I think you shouldn't need to assert to *UnixConn for WriteTo.

[mikio, 2014-04-02 10:42:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=d78036c3351f ***

net: make WriteTo, WriteToUnix and WriteMsgUnix fail when connectionless-mode
UnixConn is already connected

This CL tries to fill the gap between Linux and other Unix-like systems
in the same way UDPConn already did.

Fixes issue 7677.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/83330045

https://codereview.appspot.com/83330045/diff/40001/src/pkg/net/unix_test.go
File src/pkg/net/unix_test.go (right):

https://codereview.appspot.com/83330045/diff/40001/src/pkg/net/unix_test.go#n...
src/pkg/net/unix_test.go:183: if _, err =
c.(*UnixConn).WriteTo([]byte("Connection-oriented mode socket"), raddr); err ==
nil {
On 2014/04/02 04:00:47, iant wrote:
> I think you shouldn't need to assert to *UnixConn for WriteTo.

net.Conn doesn't have WriteTo method.

[gobot, 2014-04-02 11:43:46]

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/bd04a8096fbcd4dff9b750d4089f30fb875532dd