Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1825)

Issue 8331043: Converted some tests to use unit generators

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by jeff.pihach
Modified:
11 years ago
Reviewers:
mp+156933, matthew.scott, bcsaller
Visibility:
Public.

Description

Converted some tests to use unit generators https://code.launchpad.net/~hatch/juju-gui/unit-generator/+merge/156933 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Converted some tests to use unit generators #

Patch Set 3 : Converted some tests to use unit generators #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -46 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M test/test_sandbox.js View 4 chunks +30 lines, -46 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
11 years ago (2013-04-03 18:00:30 UTC) #1
bcsaller
LGTM
11 years ago (2013-04-03 18:48:26 UTC) #2
matthew.scott
LGTM, thanks for the cleanup.
11 years ago (2013-04-03 19:04:26 UTC) #3
jeff.pihach
Thanks for the reviews!
11 years ago (2013-04-03 19:17:48 UTC) #4
jeff.pihach
11 years ago (2013-04-03 19:25:01 UTC) #5
*** Submitted:

Converted some tests to use unit generators

R=bcsaller, matthew.scott
CC=
https://codereview.appspot.com/8331043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b