state: separate infoId from entityId

state: separate infoId from entityId

As there's no longer a direct connection between mongo document and
allInfo item, having the two things represented by the same type
seems wrong, so we make the allInfo key a function of the backing
implementation.

https://code.launchpad.net/~rogpeppe/juju-core/266-state-infoid/+merge/156921

(do not edit description out of merge proposal)

[rog, 2013-04-03 17:34:18]

Please take a look.

https://codereview.appspot.com/8328043/diff/1/state/megawatcher_internal_test.go
File state/megawatcher_internal_test.go (left):

https://codereview.appspot.com/8328043/diff/1/state/megawatcher_internal_test...
state/megawatcher_internal_test.go:908: func (s *allWatcherStateSuite)
TestStateBackingChanged(c *C) {
i've removed this test because it doesn't cover ground that TestChanged doesn't
also cover (and it's hard to make it work with the new scheme)

[dimitern, 2013-04-03 17:52:26]

LGTM with some trivials.

https://codereview.appspot.com/8328043/diff/2001/state/megawatcher.go
File state/megawatcher.go (right):

https://codereview.appspot.com/8328043/diff/2001/state/megawatcher.go#newcode91
state/megawatcher.go:91: // idForInfo returns the entity id corresponding
s/entity/info/ ?

https://codereview.appspot.com/8328043/diff/2001/state/megawatcher.go#newcode175
state/megawatcher.go:175: if err := aw.backing.changed(aw.all, change); err !=
nil {
what's the "change" here?

https://codereview.appspot.com/8328043/diff/2001/state/megawatcher.go#newcode418
state/megawatcher.go:418: // idForInfo returns the entity id of the given entity
document.
s/entity/info/ ?

[fwereade, 2013-04-04 06:37:28]

LGTM

https://codereview.appspot.com/8328043/diff/2001/state/megawatcher.go
File state/megawatcher.go (right):

https://codereview.appspot.com/8328043/diff/2001/state/megawatcher.go#newcode175
state/megawatcher.go:175: if err := aw.backing.changed(aw.all, change); err !=
nil {
On 2013/04/03 17:52:26, dimitern wrote:
> what's the "change" here?

Whatever just came in from the channel :)

[rog, 2013-04-05 13:59:58]

*** Submitted:

state: separate infoId from entityId

As there's no longer a direct connection between mongo document and
allInfo item, having the two things represented by the same type
seems wrong, so we make the allInfo key a function of the backing
implementation.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/8328043

https://codereview.appspot.com/8328043/diff/2001/state/megawatcher.go
File state/megawatcher.go (right):

https://codereview.appspot.com/8328043/diff/2001/state/megawatcher.go#newcode91
state/megawatcher.go:91: // idForInfo returns the entity id corresponding
On 2013/04/03 17:52:26, dimitern wrote:
> s/entity/info/ ?

Done.

https://codereview.appspot.com/8328043/diff/2001/state/megawatcher.go#newcode418
state/megawatcher.go:418: // idForInfo returns the entity id of the given entity
document.
On 2013/04/03 17:52:26, dimitern wrote:
> s/entity/info/ ?

Done.