Issue 83270045: Disable --keyFile in mongo upstart config

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 83270045: Disable --keyFile in mongo upstart config

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by axw

Modified:
10 years ago

Reviewers:
mp+213786, fwereade, rog

Visibility:
Public.

Description

Disable --keyFile in mongo upstart config We can't enable this yet, because shared-secret isn't written until after Mongo is started. This will change when EnsureMongoServer is landed. (FWIW I did test this with local, and it worked. I don't yet understand why - it shouldn't be any different to cloud providers. I suspect there's a race here with upstart restarting Mongo, and the machine agnet writing the shared-secret.) Fixes lp:1300889 https://code.launchpad.net/~axwalk/juju-core/lp1300889-disable-mongo-keyfile/+merge/213786 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Disable --keyFile in mongo upstart config #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	agent/mongo/mongo.go	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fwereade

Add a matching comment for the commented `keyFile :=` line and LGTM. (I don't really ...

10 years ago (2014-04-02 10:01:43 UTC) #3

Please take a look.

Expand All Messages | Collapse All Messages