Issue 8321043: environs/jujutest: fix TestBootstrapAndDeploy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8321043: environs/jujutest: fix TestBootstrapAndDeploy

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rog

Modified:
11 years, 1 month ago

Reviewers:
dimitern, mp+156883, fwereade

Visibility:
Public.

Description

environs/jujutest: fix TestBootstrapAndDeploy We wait until the machine has correctly transitioned to the Dead state. This enables the live tests to pass. (I still see TestStartStop fail sometimes though, although it runs fine on its own). https://code.launchpad.net/~rogpeppe/juju-core/223-jujutest-fix-deploy-test/+merge/156883 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/jujutest: fix TestBootstrapAndDeploy #

Patch Set 3 : environs/jujutest: fix TestBootstrapAndDeploy #

Patch Set 4 : environs/jujutest: fix TestBootstrapAndDeploy #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -15 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	2 chunks	+35 lines, -11 lines	0 comments	Download
M	state/machine.go	View	3 chunks	+17 lines, -1 line	0 comments	Download
M	state/machine_test.go	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

LGTM, likewise. Have you tried it with openstack live tests?

11 years, 1 month ago (2013-04-03 15:42:28 UTC) #4

rog

11 years, 1 month ago (2013-04-03 15:46:10 UTC) #5

*** Submitted:

environs/jujutest: fix TestBootstrapAndDeploy

We wait until the machine has correctly transitioned to
the Dead state.

This enables the live tests to pass.
(I still see TestStartStop fail sometimes though,
although it runs fine on its own).

R=fwereade, dimitern
CC=
https://codereview.appspot.com/8321043

Expand All Messages | Collapse All Messages