Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(473)

Issue 83200043: provisioner: Start instances with networks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by dimitern
Modified:
9 years, 12 months ago
Reviewers:
mp+213647, fwereade
Visibility:
Public.

Description

provisioner: Start instances with networks Provisioner worker is made aware of networks specified for a machine and passes them to the providers when starting instances. This involves a few extra things: * cloudinit.MachineConfig now has IncludeNetworks and ExcludeNetworks params and they can be set using NewMachineConfig(); * StartInstanceParams.Networks dropped and now networks are specified via SIP.MachineConfig; * provisioner gets specified machine networks and passes them through StartInstanceParams.MachineConfig to the providers; * all providers except maas changed to return an error in StartInstance() when networks are specified (using MachineConfig.HasNetworks()). All changes are unit-tested and live-tested on MaaS. Next steps: get list of networks from the provider, setup cloudinit scripts to configure the networks (failing with unknown ones) and update the machine with the actually installed networks, so they can be shown in status. https://code.launchpad.net/~dimitern/juju-core/380-provisioner-honors-networks/+merge/213647 Requires: https://code.launchpad.net/~dimitern/juju-core/379-api-provisioner-networks/+merge/213433 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 14

Patch Set 2 : provisioner: Start instances with networks #

Total comments: 4

Patch Set 3 : provisioner: Start instances with networks #

Patch Set 4 : provisioner: Start instances with networks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -116 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cloudinit/sshinit/configure_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M container/kvm/live_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M container/testing/common.go View 1 1 chunk +1 line, -1 line 0 comments Download
M environs/broker.go View 1 2 chunks +0 lines, -9 lines 0 comments Download
M environs/cloudinit.go View 1 3 chunks +10 lines, -7 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M environs/jujutest/livetests.go View 1 1 chunk +1 line, -1 line 0 comments Download
M juju/testing/instance.go View 1 3 chunks +10 lines, -6 lines 0 comments Download
M provider/azure/environ.go View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M provider/common/bootstrap_test.go View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M provider/common/mock_test.go View 1 2 chunks +7 lines, -2 lines 0 comments Download
M provider/dummy/environs.go View 1 2 3 3 chunks +20 lines, -17 lines 0 comments Download
M provider/ec2/ec2.go View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M provider/joyent/environ_instance.go View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M provider/local/environ.go View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M provider/maas/environ.go View 1 2 3 2 chunks +15 lines, -10 lines 0 comments Download
M provider/maas/environ_whitebox_test.go View 1 2 3 5 chunks +15 lines, -20 lines 0 comments Download
M provider/openstack/provider.go View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M state/statecmd/machineconfig.go View 1 1 chunk +7 lines, -1 line 0 comments Download
M worker/provisioner/kvm-broker.go View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M worker/provisioner/kvm-broker_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M worker/provisioner/lxc-broker.go View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M worker/provisioner/lxc-broker_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M worker/provisioner/provisioner.go View 1 2 3 1 chunk +2 lines, -7 lines 0 comments Download
M worker/provisioner/provisioner_task.go View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M worker/provisioner/provisioner_test.go View 1 2 3 8 chunks +46 lines, -22 lines 0 comments Download

Messages

Total messages: 6
dimitern
Please take a look.
10 years ago (2014-04-01 13:03:40 UTC) #1
fwereade
mostly just recording stuff we discussed live https://codereview.appspot.com/83200043/diff/1/container/testing/common.go File container/testing/common.go (right): https://codereview.appspot.com/83200043/diff/1/container/testing/common.go#newcode23 container/testing/common.go:23: machineConfig := ...
9 years, 12 months ago (2014-04-01 15:39:49 UTC) #2
dimitern
Please take a look. https://codereview.appspot.com/83200043/diff/1/container/testing/common.go File container/testing/common.go (right): https://codereview.appspot.com/83200043/diff/1/container/testing/common.go#newcode23 container/testing/common.go:23: machineConfig := environs.NewMachineConfig(machineId, "fake-nonce", nil, ...
9 years, 12 months ago (2014-04-01 16:34:51 UTC) #3
fwereade
LGTM, just trivials now. We will want to move those fields of MachineConfig before too ...
9 years, 12 months ago (2014-04-01 17:17:29 UTC) #4
dimitern
Please take a look. https://codereview.appspot.com/83200043/diff/20001/provider/azure/environ.go File provider/azure/environ.go (right): https://codereview.appspot.com/83200043/diff/20001/provider/azure/environ.go#newcode389 provider/azure/environ.go:389: len(args.MachineConfig.ExcludeNetworks) > 0 { On ...
9 years, 12 months ago (2014-04-02 07:48:58 UTC) #5
dimitern
9 years, 12 months ago (2014-04-02 10:08:22 UTC) #6
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b