bzr: add package to handle Bazaar branches

bzr: add package to handle Bazaar branches



https://code.launchpad.net/~niemeyer/juju-core/branch-handling/+merge/156976

(do not edit description out of merge proposal)

[niemeyer, 2013-04-03 21:21:39]

Please take a look.

[dimitern, 2013-04-04 07:59:21]

LGTM. We need this for the store, right?

https://codereview.appspot.com/8319045/diff/1/bzr/bzr.go
File bzr/bzr.go (right):

https://codereview.appspot.com/8319045/diff/1/bzr/bzr.go#newcode38
bzr/bzr.go:38: // In other words, if b's location is "lp:foo", and parts is
{"bar, baz"},
s/parts is/parts are/ ?

[niemeyer, 2013-04-04 12:58:50]

This is another step towards having "juju publish" working.

https://codereview.appspot.com/8319045/diff/1/bzr/bzr.go
File bzr/bzr.go (right):

https://codereview.appspot.com/8319045/diff/1/bzr/bzr.go#newcode38
bzr/bzr.go:38: // In other words, if b's location is "lp:foo", and parts is
{"bar, baz"},
On 2013/04/04 07:59:21, dimitern wrote:
> s/parts is/parts are/ ?

It works either way in this case:

    "the parts variable is"
    "the parts are"

I intended for it to be the former.

[niemeyer, 2013-04-04 19:41:13]

Please take a look.

[TheMue, 2013-04-05 12:41:21]

LGTM, only one minor comment.

https://codereview.appspot.com/8319045/diff/6001/bzr/bzr.go
File bzr/bzr.go (right):

https://codereview.appspot.com/8319045/diff/6001/bzr/bzr.go#newcode44
bzr/bzr.go:44: panic("no point in runing bzr without arguments here")
How about something like

bzr(command string, args ...string) string

to avoid calls without arguments leading to a runtime error instead of a
compiling error (Even if it's private and is today not used without arguments.)?

[niemeyer, 2013-04-05 14:15:45]

https://codereview.appspot.com/8319045/diff/6001/bzr/bzr.go
File bzr/bzr.go (right):

https://codereview.appspot.com/8319045/diff/6001/bzr/bzr.go#newcode44
bzr/bzr.go:44: panic("no point in runing bzr without arguments here")
On 2013/04/05 12:41:21, TheMue wrote:
> How about something like
> 
> bzr(command string, args ...string) string
> 
> to avoid calls without arguments leading to a runtime error instead of a
> compiling error (Even if it's private and is today not used without
arguments.)?

That's a good idea, thanks. Will do.

[niemeyer, 2013-04-05 19:24:57]

*** Submitted:

bzr: add package to handle Bazaar branches

R=dimitern, TheMue
CC=
https://codereview.appspot.com/8319045