Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(529)

Issue 83130045: worker/peergrouper: use mongo.SelectPeerHostPort

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by wwitzel
Modified:
6 years, 6 months ago
Reviewers:
wwitzel3, mp+213871, rog
Visibility:
Public.

Description

worker/peergrouper: use mongo.SelectPeerHostPort This will ensure that we are using the same method for getting the peer hostPort even if the implementation details of SelectInternalHostPort change. https://code.launchpad.net/~wwitzel3/juju-core/005-ha-worker-peergrouper/+merge/213871 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : worker/peergrouper: use mongo.SelectPeerHostPort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -7 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M agent/mongo/mongo.go View 1 chunk +6 lines, -0 lines 0 comments Download
M agent/mongo/mongo_test.go View 1 1 chunk +23 lines, -6 lines 0 comments Download
M worker/peergrouper/worker.go View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
wwitzel
Please take a look.
6 years, 6 months ago (2014-04-02 15:23:17 UTC) #1
wwitzel3
Tested live with local maas and ec2.
6 years, 6 months ago (2014-04-02 15:41:45 UTC) #2
rog
LGTM with a couple of trivial suggestions. https://codereview.appspot.com/83130045/diff/1/agent/mongo/mongo_test.go File agent/mongo/mongo_test.go (right): https://codereview.appspot.com/83130045/diff/1/agent/mongo/mongo_test.go#newcode168 agent/mongo/mongo_test.go:168: hostPorts := ...
6 years, 6 months ago (2014-04-02 15:45:20 UTC) #3
wwitzel3
https://codereview.appspot.com/83130045/diff/1/agent/mongo/mongo_test.go File agent/mongo/mongo_test.go (right): https://codereview.appspot.com/83130045/diff/1/agent/mongo/mongo_test.go#newcode168 agent/mongo/mongo_test.go:168: hostPorts := []instance.HostPort{ On 2014/04/02 15:45:20, rog wrote: > ...
6 years, 6 months ago (2014-04-02 16:16:51 UTC) #4
wwitzel
6 years, 6 months ago (2014-04-02 16:19:19 UTC) #5
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b