worker/peergrouper: use mongo.SelectPeerHostPort

worker/peergrouper: use mongo.SelectPeerHostPort

This will ensure that we are using the same method for getting the peer
hostPort even if the implementation details of SelectInternalHostPort change.

https://code.launchpad.net/~wwitzel3/juju-core/005-ha-worker-peergrouper/+merge/213871

(do not edit description out of merge proposal)

[wwitzel, 2014-04-02 15:23:17]

Please take a look.

[wwitzel3, 2014-04-02 15:41:45]

Tested live with local maas and ec2.

[rog, 2014-04-02 15:45:20]

LGTM with a couple of trivial suggestions.

https://codereview.appspot.com/83130045/diff/1/agent/mongo/mongo_test.go
File agent/mongo/mongo_test.go (right):

https://codereview.appspot.com/83130045/diff/1/agent/mongo/mongo_test.go#newc...
agent/mongo/mongo_test.go:168: hostPorts := []instance.HostPort{
it's quite nice to make this kind of initialisation a little more compact: 

hostPorts := []instance.HostPort{{
	Address: instance.Address{
		Value:        "10.0.0.1",
		Type:         instance.Ipv4Address,
		NetworkName:  "cloud",
		NetworkScope: instance.NetworkCloudLocal,
	},
	Port: 37017,
}, {
	Address: instance.Address{
		Value:        "8.8.8.8",
		Type:         instance.Ipv4Address,
		NetworkName:  "public",
		NetworkScope: instance.NetworkPublic,
	},
	Port: 37017,
}}

https://codereview.appspot.com/83130045/diff/1/worker/peergrouper/worker.go
File worker/peergrouper/worker.go (right):

https://codereview.appspot.com/83130045/diff/1/worker/peergrouper/worker.go#n...
worker/peergrouper/worker.go:17: "launchpad.net/tomb"
this should go in its own section, just after "time"

[wwitzel3, 2014-04-02 16:16:51]

https://codereview.appspot.com/83130045/diff/1/agent/mongo/mongo_test.go
File agent/mongo/mongo_test.go (right):

https://codereview.appspot.com/83130045/diff/1/agent/mongo/mongo_test.go#newc...
agent/mongo/mongo_test.go:168: hostPorts := []instance.HostPort{
On 2014/04/02 15:45:20, rog wrote:
> it's quite nice to make this kind of initialisation a little more compact: 
> 
> hostPorts := []instance.HostPort{{
> 	Address: instance.Address{
> 		Value:        "10.0.0.1",
> 		Type:         instance.Ipv4Address,
> 		NetworkName:  "cloud",
> 		NetworkScope: instance.NetworkCloudLocal,
> 	},
> 	Port: 37017,
> }, {
> 	Address: instance.Address{
> 		Value:        "8.8.8.8",
> 		Type:         instance.Ipv4Address,
> 		NetworkName:  "public",
> 		NetworkScope: instance.NetworkPublic,
> 	},
> 	Port: 37017,
> }}

Done.

https://codereview.appspot.com/83130045/diff/1/worker/peergrouper/worker.go
File worker/peergrouper/worker.go (right):

https://codereview.appspot.com/83130045/diff/1/worker/peergrouper/worker.go#n...
worker/peergrouper/worker.go:17: "launchpad.net/tomb"
On 2014/04/02 15:45:20, rog wrote:
> this should go in its own section, just after "time"

Done.

[wwitzel, 2014-04-02 16:19:19]

Please take a look.