Issue 83100047: code review 83100047: runtime: revert change to PoisonPtr value

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 83100047: code review 83100047: runtime: revert change to PoisonPtr value (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rsc

Modified:
11 years, 7 months ago

Reviewers:
khr1

CC:
khr, golang-codereviews

Visibility:
Public.

Description

runtime: revert change to PoisonPtr value Submitted accidentally in CL 83630044. Fixes various builds.

Patch Set 1 #

Patch Set 2 : diff -r 5052ec3ce1c1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5052ec3ce1c1 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/malloc.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello khr (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2014-04-02 20:55:32 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=38b8fac81a2c *** runtime: revert change to PoisonPtr value Submitted accidentally in CL ...

11 years, 7 months ago (2014-04-02 20:55:37 UTC) #2

khr1

LGTM. On Wed, Apr 2, 2014 at 1:55 PM, <rsc@golang.org> wrote: > *** Submitted as ...

11 years, 7 months ago (2014-04-02 20:57:16 UTC) #3

rsc

11 years, 7 months ago (2014-04-02 22:54:43 UTC) #4

FWIW, I was playing with alternate values because it appears that at least
under certain circumstances, attempts to dereference the current poison
value makes an OS X process wedge instead of dying with the usual message.
I don't know whose fault it is (maybe OS X's!).

Expand All Messages | Collapse All Messages