Issue 83080044: migrate Maps Engine sample to Discovery

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by jlivni

Modified:
9 years, 12 months ago

Reviewers:
jcgregorio_google, Ali Afshar, jasmuth

CC:
gdata-python-client-library-contributors_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -94 lines)			Patch
M	samples/maps_engine/maps_engine.py	View	4 chunks	+53 lines, -93 lines	0 comments	Download
A	samples/maps_engine/polygons.dbf	View	Binary file		0 comments	Download
M	samples/maps_engine/polygons.prj	View	1 chunk	+1 line, -1 line	0 comments	Download
A	samples/maps_engine/polygons.shp	View	Binary file		0 comments	Download
A	samples/maps_engine/polygons.shx	View	Binary file		0 comments	Download

Messages

Total messages: 13

Expand All Messages | Collapse All Messages

jcgregorio_google

On 2014/04/01 15:31:45, Ali Afshar wrote: > LGTM Committed in https://code.google.com/p/google-api-python-client/source/detail?r=868a4c52c5603e3284c93f89b3f0d8238622d309

10 years ago (2014-04-09 18:12:42 UTC) #3

jlivni

Hmm - something seems wrong with the commit. Not all the files were added, and ...

10 years ago (2014-04-09 18:29:05 UTC) #4

jcgregorio_google

Rolled back, let me try that again. On Wed, Apr 9, 2014 at 2:28 PM, ...

10 years ago (2014-04-09 18:39:26 UTC) #5

jcgregorio_google

How was this patch created? In the patch file it says "GIT binary patch", mercurial ...

10 years ago (2014-04-09 18:46:08 UTC) #6

jlivni

I used the upload-diffs.py command on a fresh mercurial clone of the samples On Wed, ...

10 years ago (2014-04-09 18:50:15 UTC) #7

jcgregorio_google

I've added you as a committer, see if you can submit it yourself. -joe On ...

10 years ago (2014-04-14 12:28:02 UTC) #8

jlivni

Cool. Just back from vacation, also I've never really used rietveld .. do I just ...

9 years, 12 months ago (2014-04-24 23:00:42 UTC) #10

jcgregorio_google

Oh, I thought this had landed, guess you need to try to land it in ...

9 years, 12 months ago (2014-04-25 02:55:49 UTC) #11

Oh, I thought this had landed, guess you need to try to land it in Git now:


https://groups.google.com/forum/#!topic/google-api-python-client/az9VexXz96A

  -joe


On Thu, Apr 24, 2014 at 7:00 PM, Josh Livni <jlivni@google.com> wrote:

> Cool.  Just back from vacation, also I've never really used rietveld .. do
> I just do a regular hg commit from command line, or is there should I be
> committing it somehow through the codereview site itself to associate the
> patch <https://codereview.appspot.com/83080044/> with the commit?
>
>
> On Mon, Apr 14, 2014 at 5:27 AM, Joe Gregorio <jcgregorio@google.com>wrote:
>
>> I've added you as a committer, see if you can submit it yourself.
>>
>>   -joe
>>
>>
>> On Wed, Apr 9, 2014 at 2:49 PM, Josh Livni <jlivni@google.com> wrote:
>>
>>> I used the upload-diffs.py command on a fresh mercurial clone of the
>>> samples
>>>
>>>
>>> On Wed, Apr 9, 2014 at 11:45 AM, Joe Gregorio <jcgregorio@google.com>wrote:
>>>
>>>> How was this patch created? In the patch file it says "GIT binary
>>>> patch",  mercurial fails to apply it correctly and "patch -p0" simply
>>>> ignores those changes.
>>>>
>>>>
>>>>
>>>>
>>>> On Wed, Apr 9, 2014 at 2:39 PM, Joe Gregorio <jcgregorio@google.com>wrote:
>>>>
>>>>> Rolled back, let me try that again.
>>>>>
>>>>>
>>>>> On Wed, Apr 9, 2014 at 2:28 PM, Josh Livni <jlivni@google.com> wrote:
>>>>>
>>>>>> Hmm - something seems wrong with the commit.  Not all the files were
>>>>>> added, and it seems the maps_engine.py is now just a couple lines of
junk
>>>>>> text?
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, Apr 9, 2014 at 11:12 AM, <jcgregorio@google.com> wrote:
>>>>>>
>>>>>>> On 2014/04/01 15:31:45, Ali Afshar wrote:
>>>>>>>
>>>>>>>> LGTM
>>>>>>>>
>>>>>>>
>>>>>>> Committed in
>>>>>>> https://code.google.com/p/google-api-python-client/source/detail?r=
>>>>>>> 868a4c52c5603e3284c93f89b3f0d8238622d309
>>>>>>>
>>>>>>> https://codereview.appspot.com/83080044/
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

jlivni

Sweet - first pull request created! https://github.com/google/google-api-python-client/pull/1 FWIW I noticed all the maps engine samples ...

9 years, 12 months ago (2014-04-25 17:04:43 UTC) #12

Sweet - first pull request created!
https://github.com/google/google-api-python-client/pull/1

FWIW I noticed all the maps engine samples were gone from github version;
perhaps the migration came from the latest release of the client vs the tip
branch of the codesite project?  Not sure if there were fixes in there that
may have also been lost.


On Thu, Apr 24, 2014 at 7:55 PM, Joe Gregorio <jcgregorio@google.com> wrote:

> Oh, I thought this had landed, guess you need to try to land it in Git now:
>
>
> https://groups.google.com/forum/#!topic/google-api-python-client/az9VexXz96A
>
>   -joe
>
>
> On Thu, Apr 24, 2014 at 7:00 PM, Josh Livni <jlivni@google.com> wrote:
>
>> Cool.  Just back from vacation, also I've never really used rietveld ..
>> do I just do a regular hg commit from command line, or is there should I be
>> committing it somehow through the codereview site itself to associate the
>> patch <https://codereview.appspot.com/83080044/> with the commit?
>>
>>
>> On Mon, Apr 14, 2014 at 5:27 AM, Joe Gregorio <jcgregorio@google.com>wrote:
>>
>>> I've added you as a committer, see if you can submit it yourself.
>>>
>>>   -joe
>>>
>>>
>>> On Wed, Apr 9, 2014 at 2:49 PM, Josh Livni <jlivni@google.com> wrote:
>>>
>>>> I used the upload-diffs.py command on a fresh mercurial clone of the
>>>> samples
>>>>
>>>>
>>>> On Wed, Apr 9, 2014 at 11:45 AM, Joe Gregorio
<jcgregorio@google.com>wrote:
>>>>
>>>>> How was this patch created? In the patch file it says "GIT binary
>>>>> patch",  mercurial fails to apply it correctly and "patch -p0" simply
>>>>> ignores those changes.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Apr 9, 2014 at 2:39 PM, Joe Gregorio
<jcgregorio@google.com>wrote:
>>>>>
>>>>>> Rolled back, let me try that again.
>>>>>>
>>>>>>
>>>>>> On Wed, Apr 9, 2014 at 2:28 PM, Josh Livni <jlivni@google.com> wrote:
>>>>>>
>>>>>>> Hmm - something seems wrong with the commit.  Not all the files were
>>>>>>> added, and it seems the maps_engine.py is now just a couple lines of
junk
>>>>>>> text?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Apr 9, 2014 at 11:12 AM, <jcgregorio@google.com> wrote:
>>>>>>>
>>>>>>>> On 2014/04/01 15:31:45, Ali Afshar wrote:
>>>>>>>>
>>>>>>>>> LGTM
>>>>>>>>>
>>>>>>>>
>>>>>>>> Committed in
>>>>>>>> https://code.google.com/p/google-api-python-client/source/detail?r=
>>>>>>>> 868a4c52c5603e3284c93f89b3f0d8238622d309
>>>>>>>>
>>>>>>>> https://codereview.appspot.com/83080044/
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

jasmuth

9 years, 12 months ago (2014-04-25 17:12:17 UTC) #13

The github repos were automatically created with a script that cloned the 
codesite repo. What specifically is missing? Maybe I messed something up.

Probably best if you filed an issue on the github tracker (which I forgot 
to enable until 2 minutes ago).

- John

On Friday, April 25, 2014 1:04:23 PM UTC-4, Josh Livni wrote:
>
> Sweet - first pull request created! 
> https://github.com/google/google-api-python-client/pull/1
>
> FWIW I noticed all the maps engine samples were gone from github version; 
> perhaps the migration came from the latest release of the client vs the tip 
> branch of the codesite project?  Not sure if there were fixes in there that 
> may have also been lost.
>
>
> On Thu, Apr 24, 2014 at 7:55 PM, Joe Gregorio <jcgregorio@google.com>wrote:
>
>> Oh, I thought this had landed, guess you need to try to land it in Git 
>> now:
>>
>>   
>> https://groups.google.com/forum/#!topic/google-api-python-client/az9VexXz96A
>>  
>>   -joe
>>
>>
>> On Thu, Apr 24, 2014 at 7:00 PM, Josh Livni <jlivni@google.com> wrote:
>>
>>> Cool.  Just back from vacation, also I've never really used rietveld .. 
>>> do I just do a regular hg commit from command line, or is there should I be

>>> committing it somehow through the codereview site itself to associate the 
>>> patch <https://codereview.appspot.com/83080044/> with the commit?
>>>  
>>>
>>> On Mon, Apr 14, 2014 at 5:27 AM, Joe Gregorio <jcgregorio@google.com>wrote:
>>>
>>>> I've added you as a committer, see if you can submit it yourself.
>>>>
>>>>   -joe
>>>>
>>>>
>>>> On Wed, Apr 9, 2014 at 2:49 PM, Josh Livni <jlivni@google.com> wrote:
>>>>
>>>>> I used the upload-diffs.py command on a fresh mercurial clone of the 
>>>>> samples
>>>>>
>>>>>
>>>>> On Wed, Apr 9, 2014 at 11:45 AM, Joe Gregorio
<jcgregorio@google.com>wrote:
>>>>>
>>>>>> How was this patch created? In the patch file it says "GIT binary 
>>>>>> patch",  mercurial fails to apply it correctly and "patch -p0" simply 
>>>>>> ignores those changes.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, Apr 9, 2014 at 2:39 PM, Joe Gregorio
<jcgregorio@google.com>wrote:
>>>>>>
>>>>>>> Rolled back, let me try that again.
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Apr 9, 2014 at 2:28 PM, Josh Livni <jlivni@google.com>wrote:
>>>>>>>
>>>>>>>> Hmm - something seems wrong with the commit.  Not all the files 
>>>>>>>> were added, and it seems the maps_engine.py is now just a couple lines
of 
>>>>>>>> junk text?
>>>>>>>>  
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, Apr 9, 2014 at 11:12 AM, <jcgregorio@google.com> wrote:
>>>>>>>>
>>>>>>>>> On 2014/04/01 15:31:45, Ali Afshar wrote:
>>>>>>>>>
>>>>>>>>>> LGTM
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Committed in
>>>>>>>>> https://code.google.com/p/google-api-python-client/
>>>>>>>>> source/detail?r=868a4c52c5603e3284c93f89b3f0d8238622d309
>>>>>>>>>
>>>>>>>>> https://codereview.appspot.com/83080044/
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

Expand All Messages | Collapse All Messages