Issue 83060049: juju deploy set service owner as current user

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 83060049: juju deploy set service owner as current user

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by mattyw

Modified:
10 years ago

Reviewers:
mp+213962, fwereade

Visibility:
Public.

Description

juju deploy set service owner as current user When a service is deployed the service owner is currently hardcoded to user-admin. After this change the owner of the service will be set to the user specified in the jenv file. https://code.launchpad.net/~mattyw/juju-core/deploy-with-user-name/+merge/213962 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : juju deploy set service owner as current user #

Total comments: 1

Patch Set 3 : juju deploy set service owner as current user #

Total comments: 1

Patch Set 4 : juju deploy set service owner as current user #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -1 line)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/conn_test.go	View	1 2 3	2 chunks	+16 lines, -0 lines	0 comments	Download
M	juju/deploy.go	View	1 2 3	2 chunks	+5 lines, -1 line	0 comments	Download
M	state/apiserver/client/client.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	state/apiserver/client/client_test.go	View	1 2	2 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

fwereade

https://codereview.appspot.com/83060049/diff/20001/cmd/juju/deploy_test.go File cmd/juju/deploy_test.go (right): https://codereview.appspot.com/83060049/diff/20001/cmd/juju/deploy_test.go#newcode266 cmd/juju/deploy_test.go:266: c.Assert(service.GetOwnerTag(), gc.Equals, "user-admin") I don't think this test demonstrates ...

10 years, 1 month ago (2014-04-03 16:00:42 UTC) #2

fwereade

LGTM with a test in the juju package. https://codereview.appspot.com/83060049/diff/40001/juju/deploy.go File juju/deploy.go (right): https://codereview.appspot.com/83060049/diff/40001/juju/deploy.go#newcode59 juju/deploy.go:59: args.ServiceOwner, ...

10 years ago (2014-04-07 09:53:25 UTC) #4

Please take a look.

Expand All Messages | Collapse All Messages