Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(218)

Issue 83046: Fix crash when a stencil routine is missing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by Patrick McCarty
Modified:
9 years, 9 months ago
Reviewers:
joeneeman, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix crash when a stencil routine is missing example: using embedded-ps with -dbackend=svg - Remove obsolete code from lily.scm that was used before the output backends took their current form. - Remove exported bindings from output-ps.scm; the output backends no longer use a `public interface', since all work is done with ly:outputter-dump-stencil, which uses the modules directly. - Reorganize define-stencil-commands.scm and add a couple of missing stencil commands. - Use a generic procedure (backend-testing) for the current output backend to emit warnings if a stencil routine is missing. Additionally, return an empty string (null string) for missing routines. - Create a new program option (-dwarning-as-error) that will cause LilyPond to exit with an error for all warnings and programming_errors. It is disabled by default. - In the `placebox' stencil routine, check for an empty string before execution.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a new program option and use a single procedure for all output backends #

Patch Set 3 : Same as Patch Set 2, except for a merge fix in output-ps.scm #

Patch Set 4 : Reorganize define-stencil-commands.scm logically #

Patch Set 5 : Make -dwarning-as-error a general option #

Patch Set 6 : Resolve conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -94 lines) Patch
M lily/grob.cc View 4 chunks +8 lines, -1 line 0 comments Download
M lily/input.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M lily/paper-outputter.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M lily/program-option-scheme.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M scm/backend-library.scm View 2 3 4 3 chunks +15 lines, -2 lines 0 comments Download
M scm/define-stencil-commands.scm View 4 5 3 chunks +20 lines, -11 lines 0 comments Download
M scm/lily.scm View 1 2 3 4 5 3 chunks +8 lines, -10 lines 0 comments Download
M scm/output-ps.scm View 1 2 3 4 2 chunks +4 lines, -31 lines 0 comments Download
M scm/output-socket.scm View 1 2 3 4 2 chunks +3 lines, -13 lines 0 comments Download
M scm/output-svg.scm View 1 2 3 4 5 2 chunks +15 lines, -23 lines 0 comments Download

Messages

Total messages: 3
hanwenn
Can this be made so that the regtests and similar crash when an unknown stencil ...
9 years, 10 months ago (2009-07-02 02:36:41 UTC) #1
joeneeman
http://codereview.appspot.com/83046/diff/1/3 File scm/output-ps.scm (right): http://codereview.appspot.com/83046/diff/1/3#newcode58 Line 58: (ly:all-output-backend-commands))))) Perhaps this could be a macro (so ...
9 years, 10 months ago (2009-07-02 05:19:36 UTC) #2
joeneeman
9 years, 10 months ago (2009-07-16 05:42:25 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b