Code review - Issue 83046: Fix crash when a stencil routine is missinghttps://codereview.appspot.com/2009-07-16T05:42:25+00:00rietveld
Message from unknown
2009-06-20T18:25:03+00:00Patrick McCartyurn:md5:020ef8cddd46f5f47184578d16aed31d
Message from hanwenn@gmail.com
2009-07-02T02:36:41+00:00hanwennurn:md5:6dc96619215ba69f594c42ad94945804
Can this be made so that the regtests and similar crash when an unknown stencil expression is executed? Perhaps a -d option could help here.
http://codereview.appspot.com/83046/diff/1/5
File scm/output-svg.scm (right):
http://codereview.appspot.com/83046/diff/1/5#newcode284
Line 284: (if (< 0 (string-length expr))
isnt there a function string-empty? or string-null? (or similar) to do this in a more roundabout name?
Message from joeneeman@gmail.com
2009-07-02T05:19:36+00:00joeneemanurn:md5:6ad70c53279ace80b912d16e0b43b976
http://codereview.appspot.com/83046/diff/1/3
File scm/output-ps.scm (right):
http://codereview.appspot.com/83046/diff/1/3#newcode58
Line 58: (ly:all-output-backend-commands)))))
Perhaps this could be a macro (so that you don't need to c&p for every backend). And if you add a -d option like Han-Wen suggested then you can get rid of the (if #t ...)
Message from unknown
2009-07-05T20:55:49+00:00Patrick McCartyurn:md5:4ea17513848339669e33219ac6cb543f
Message from unknown
2009-07-05T21:04:43+00:00Patrick McCartyurn:md5:51f113a23794831a93dbe1766c5eb82d
Message from unknown
2009-07-06T00:07:58+00:00Patrick McCartyurn:md5:3714dfe6e976a918a9dd8335ccd6948d
Message from unknown
2009-07-07T21:31:30+00:00Patrick McCartyurn:md5:f8f1302a1131e2f8da05246fb5e617f8
Message from unknown
2009-07-16T04:40:51+00:00Patrick McCartyurn:md5:1be29a200b08bfc866dd6533d7467e60
Message from joeneeman@gmail.com
2009-07-16T05:42:25+00:00joeneemanurn:md5:9a0a06ec2d6b676acdbd050bf51cbf82
lgtm