code review 8300044: bytes: don't leave mprotect-ed pages after unsafe test.

bytes: don't leave mprotect-ed pages after unsafe test.

Fixes inscrutable GC faults during testing.

[remyoudompheng, 2013-04-03 06:31:18]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-04-03 07:38:24]

LGTM

[dave_cheney.net, 2013-04-03 07:41:15]

LGTM. I wasn't able to reproduce the breakage on my machine, but the
logic of the test clearly leaked poisoned pages into the address
space.

On Wed, Apr 3, 2013 at 6:38 PM,  <bradfitz@golang.org> wrote:
> LGTM
>
>
> https://codereview.appspot.com/8300044/
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[albert.strasheim, 2013-04-03 09:19:52]

LGTM

Please submit.

[bradfitz, 2013-04-03 15:31:35]

*** Submitted as https://code.google.com/p/go/source/detail?r=672069179b80 ***

bytes: don't leave mprotect-ed pages after unsafe test.

Fixes inscrutable GC faults during testing.

R=golang-dev, bradfitz, dave, fullung
CC=golang-dev
https://codereview.appspot.com/8300044

Committer: Brad Fitzpatrick <bradfitz@golang.org>