Disable charm store tests that require Mongo JS.

Disable charm store tests that require Mongo JS.

Juju CI tests run against a build of MongoDB that does not support javascript
for cross-platform reasons. This causes some of the charm store tests to fail
which use map reduce to test the stats collection. Made the execution of these
tests configurable with a -mongojs suite flag, off by default.

https://code.launchpad.net/~cmars/juju-core/cs-mongo-tests/+merge/213563

(do not edit description out of merge proposal)

[cmars, 2014-04-01 00:16:08]

Please take a look.

[cmars, 2014-04-01 00:16:44]

Fix LP: #1295140

[fwereade, 2014-04-01 07:12:37]

https://codereview.appspot.com/82930043/diff/1/store/store_test.go
File store/store_test.go (right):

https://codereview.appspot.com/82930043/diff/1/store/store_test.go#newcode39
store/store_test.go:39: var mongojs *bool = flag.Bool("mongojs", false, "MongoDB
in test environment supports javascript")
LGTM *so long as* we have a path for running CI tests with mongojs somewhere.
Please coordinate with curtis.

[cmars, 2014-04-10 15:13:58]

Please take a look.

[cmars, 2014-04-10 16:23:57]

Updated per jam's suggestions:
- invert the logic, mongojs tests are on by default unless you opt-out
- support env var JUJU_NOTEST_MONGODB=1 to disable mongojs tests

[cmars, 2014-04-10 16:31:54]

On 2014/04/10 16:23:57, cmars wrote:
> Updated per jam's suggestions:
> - invert the logic, mongojs tests are on by default unless you opt-out
> - support env var JUJU_NOTEST_MONGODB=1 to disable mongojs tests

Correction: it's JUJU_NOTEST_MONGOJS=1

[jameinel, 2014-04-10 17:15:22]

LGTM.

I slightly prefer the positive form:
JUJU_TEST_MONGOJS=disable
or something like that, but I still think this is better than not having it.