Issue 8281044: code review 8281044: doc: add prominent download button to getting started page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8281044: code review 8281044: doc: add prominent download button to getting started page (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by adg

Modified:
12 years ago

Reviewers:

CC:
golang-dev, kisielk, r

Visibility:
Public.

Description

doc: add prominent download button to getting started page Also remove the introduction, which says what the rest of the page says anyway. Fixes issue 5182.

Patch Set 2 : diff -r 47053fd8f41e https://code.google.com/p/go #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -34 lines)			Patch
	M	doc/install.html	View	1	2 chunks	+20 lines, -34 lines	0 comments	Download
	M	doc/style.css	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years ago (2013-04-03 02:32:54 UTC) #1

kisielk

https://codereview.appspot.com/8281044/diff/1/doc/install.html File doc/install.html (right): https://codereview.appspot.com/8281044/diff/1/doc/install.html#newcode6 doc/install.html:6: <h2 id="download">Download the Go tools</h2> s/tools/distribution/ ? That's what ...

12 years ago (2013-04-03 04:45:08 UTC) #2

LGTM https://codereview.appspot.com/8281044/diff/1/doc/install.html File doc/install.html (right): https://codereview.appspot.com/8281044/diff/1/doc/install.html#newcode24 doc/install.html:24: for the FreeBSD, Linux, Mac OS X (Snow ...

12 years ago (2013-04-03 04:46:16 UTC) #3

adg

12 years ago (2013-04-03 04:59:30 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=08977bd0dda2 ***

doc: add prominent download button to getting started page

Also remove the introduction, which says what the rest of the
page says anyway.

Fixes issue 5182.

R=golang-dev, kamil.kisiel, r
CC=golang-dev
https://codereview.appspot.com/8281044

https://codereview.appspot.com/8281044/diff/1/doc/install.html
File doc/install.html (right):

https://codereview.appspot.com/8281044/diff/1/doc/install.html#newcode6
doc/install.html:6: <h2 id="download">Download the Go tools</h2>
On 2013/04/03 04:45:09, kisielk wrote:
> s/tools/distribution/ ? That's what it's called below.

Done.

https://codereview.appspot.com/8281044/diff/1/doc/install.html#newcode24
doc/install.html:24: for the FreeBSD, Linux, Mac OS X (Snow Leopard/Lion),
NetBSD, and Windows operating systems
On 2013/04/03 04:46:17, r wrote:
> Mountain Lion too.

Done.

https://codereview.appspot.com/8281044/diff/1/doc/install.html#newcode31
doc/install.html:31: OS/arch combination you may want to try
On 2013/04/03 04:46:17, r wrote:
> combination of operating system and architecture

Done.

Expand All Messages | Collapse All Messages