Issue 8279043: code review 8279043: net/smtp: allow PLAIN auth when advertised

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8279043: code review 8279043: net/smtp: allow PLAIN auth when advertised (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by bradfitz

Modified:
12 years, 8 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

net/smtp: allow PLAIN auth when advertised The smtp package originally allowed PLAIN whenever, but then the TLS check was added for paranoia, but it's too paranoid: it prevents using PLAIN auth even from localhost to localhost when the server advertises PLAIN support. This CL also permits the client to send PLAIN if the server advertises it. Fixes Issue 5184

Patch Set 1 #

Patch Set 2 : diff -r 885d03382eb5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 885d03382eb5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0539b18dd23b https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -1 line)			Patch
	M	src/pkg/net/smtp/auth.go	View	1	1 chunk	+10 lines, -1 line	0 comments	Download
	M	src/pkg/net/smtp/smtp_test.go	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2013-04-02 19:22:21 UTC) #1

bradfitz

12 years, 8 months ago (2013-04-03 17:52:23 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=e7f1ff6710b3 ***

net/smtp: allow PLAIN auth when advertised

The smtp package originally allowed PLAIN whenever, but then
the TLS check was added for paranoia, but it's too paranoid:
it prevents using PLAIN auth even from localhost to localhost
when the server advertises PLAIN support.

This CL also permits the client to send PLAIN if the server
advertises it.

Fixes Issue 5184

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/8279043

Expand All Messages | Collapse All Messages