code review 8274046: net/smtp: add examples

net/smtp: add examples

[kisielk, 2013-04-04 21:14:34]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-06-05 22:27:43]

https://codereview.appspot.com/8274046/diff/8001/src/pkg/net/smtp/example_tes...
File src/pkg/net/smtp/example_test.go (right):

https://codereview.appspot.com/8274046/diff/8001/src/pkg/net/smtp/example_tes...
src/pkg/net/smtp/example_test.go:29: defer wc.Close()
I wouldn't use defer here.

https://codereview.appspot.com/8274046/diff/8001/src/pkg/net/smtp/example_tes...
src/pkg/net/smtp/example_test.go:30: buf := bytes.NewBufferString("This is the
email body.")
NewBufferString isn't commonly used.  I'd prefer the example just do:

if _, err := fmt.Fprintf(wc, "This is the email body"); err != nil

Then:

wc.Close()

... and checking Close's error too.

[kisielk, 2013-06-13 15:17:25]

Also fixed a few other spots where I wasn't checking errors like I was supposed
to.

PTAL.

https://codereview.appspot.com/8274046/diff/8001/src/pkg/net/smtp/example_tes...
File src/pkg/net/smtp/example_test.go (right):

https://codereview.appspot.com/8274046/diff/8001/src/pkg/net/smtp/example_tes...
src/pkg/net/smtp/example_test.go:29: defer wc.Close()
On 2013/06/05 22:27:43, bradfitz wrote:
> I wouldn't use defer here.

Done

https://codereview.appspot.com/8274046/diff/8001/src/pkg/net/smtp/example_tes...
src/pkg/net/smtp/example_test.go:30: buf := bytes.NewBufferString("This is the
email body.")
On 2013/06/05 22:27:43, bradfitz wrote:
> NewBufferString isn't commonly used.  I'd prefer the example just do:
> 
> if _, err := fmt.Fprintf(wc, "This is the email body"); err != nil
> 
> Then:
> 
> wc.Close()
> 
> ... and checking Close's error too.

Done

[gobot, 2013-12-20 16:21:38]

Replacing golang-dev with golang-codereviews.

[bradfitz, 2014-01-16 18:49:51]

LGTM

[bradfitz, 2014-01-16 18:50:00]

*** Submitted as https://code.google.com/p/go/source/detail?r=57cda04cc69d ***

net/smtp: add examples

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/8274046

Committer: Brad Fitzpatrick <bradfitz@golang.org>