Add point-and-click to SVG output

Add point-and-click to SVG output

[Graham Percival, 2013-04-05 23:23:15]

close links

[dak, 2013-04-06 09:25:57]

https://codereview.appspot.com/8273045/diff/2001/scm/output-svg.scm
File scm/output-svg.scm (right):

https://codereview.appspot.com/8273045/diff/2001/scm/output-svg.scm#newcode545
scm/output-svg.scm:545: (if close-link
This code is too horrible to contemplate.  Setting a global variable in this
manner for passing state is not appropriate.  I suggest that you instead pass
the result of calling grob-cause as an argument to no-origin.  That would be in
line 61 in lily/stencil-interpret.cc.  That way, no-origin has a better way of
figuring out its best course of action.  Renaming no-origin to end-grob-cause in
the process might be prudent as well.

I actually can't see immediately from the code how one would arrive at the
grob-cause expression.  Can (*func), apparently a void function (?) be made to
return it by default?

At any rate, we need a better way for the relevant information to travel from
grob-cause to no-origin than the current one.  Perhaps both can be morphed into
a single call returning a format string that is then applied to the formatted
entity in question?

[Graham Percival, 2013-04-07 00:12:06]

On 2013/04/06 09:25:57, dak wrote:
> I actually can't see immediately from the code how one would arrive at the
> grob-cause expression.  Can (*func), apparently a void function (?) be made to
> return it by default?

No clue; this involves a dark part of lilypond.

void
interpret_stencil_expression (SCM expr,
                              void (*func) (void *, SCM),
                              void *func_arg,
                              Offset o)
{

I've never seen the second argument for a C++ function.  I guess it's a function
pointer for a function which takes a void* and SCM?  Certain when
interpret_stencil_expression is called within lily/*.cc it's given a void
function.

[janek, 2013-11-14 17:23:53]

Just FYI (since i was wondering myself): this morphed into
https://codereview.appspot.com/8974043 and was eventually pushed as
9621fd600e1153146ebd4326f40eef4491396a97